Send signed proxy header to the kube service #23386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it was checking version, which was empty, signed headers were not sent, when we contacted leaf cluster's kube service
AntonAM
force-pushed
the
anton/fix-remote-kube-ip-propagation
branch
from
82220b8
to
acc10fe
Compare
tigrato
approved these changes
Mar 22, 2023
jakule
approved these changes
Mar 22, 2023
public-teleport-github-review-bot
bot
removed request for
espadolini and
Joerger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing IP pinning found a problem with accessing leaf cluster's kube service - because it was checking target server version (which is empty, we don't need it for kube service), signed headers were not sent, when we contacted leaf cluster's kube service. That resulted in connection being denied for users with IP pinning.
This PR fixes it and makes sure we send signed proxy header to the kube service.