Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scp issues #2509

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Fix scp issues #2509

merged 1 commit into from
Feb 11, 2019

Conversation

russjones
Copy link
Contributor

@russjones russjones commented Jan 19, 2019

Purpose

Fixed scp client vulnerabilities to a malicious server found by Harry Sintonen.

Implementation

  • Reject invalid directory names like . and .. to disallow setting attributes on the target directory.
  • Strip control characters from file progress.
  • Strip control characters from stderr output.

Related Issues

Fixes #2539

Fixed scp client vulnerabilities to a malicious server found by Harry
Sintonen. For more information, see the following:

https://sintonen.fi/advisories/scp-client-multiple-vulnerabilities.txt
@russjones russjones merged commit 599b8b7 into master Feb 11, 2019
@russjones russjones deleted the rjones/fix-scp branch February 11, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants