Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: enable ACLs in the certs bucket #25113

Merged
merged 1 commit into from
Apr 28, 2023
Merged

terraform: enable ACLs in the certs bucket #25113

merged 1 commit into from
Apr 28, 2023

Conversation

hugoShaka
Copy link
Contributor

@hugoShaka hugoShaka commented Apr 24, 2023 •
edited

Fixes an issue that happens when creating new buckets with our HA AWS Terraform. It seems the bucket defaults changed to "no-acl" mode, which breaks Terraform. The PR reverts this change.

│ Error: error creating S3 bucket ACL for hugo-teleport13.teleportdemo.net: AccessControlListNotSupported: The bucket does not allow ACLs
│ 	status code: 400, request id: VKKR1SMCVKA9RY2B, host id: TXM+l4DymVNnhts/dPCWmsbQVG6/1MaraJMNLs9nfxyv4bYhgxHVmPQaP0z/tuwoQRZ1p6ZQWNQ=
│
│   with aws_s3_bucket_acl.certs,
│   on s3.tf line 9, in resource "aws_s3_bucket_acl" "certs":
│    9: resource "aws_s3_bucket_acl" "certs" {
│

@hugoShaka hugoShaka requested a review from tcsc April 24, 2023 20:34
@hugoShaka hugoShaka marked this pull request as ready for review April 27, 2023 22:19
@hugoShaka hugoShaka mentioned this pull request Apr 27, 2023
Closed
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from tcsc April 28, 2023 14:35
@hugoShaka hugoShaka added this pull request to the merge queue Apr 28, 2023
@hugoShaka hugoShaka added the test-plan-problem Issues which have been surfaced by running the manual release test plan label Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@hugoShaka hugoShaka added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@hugoShaka hugoShaka added this pull request to the merge queue Apr 28, 2023
Merged via the queue into master with commit 2966623 Apr 28, 2023
@hugoShaka hugoShaka deleted the hugo/fix-aws-tf-bucket-creation branch April 28, 2023 17:07
@public-teleport-github-review-bot
Copy link

@hugoShaka See the table below for backport results.

Branch Result
branch/v11 Create PR
branch/v12 Create PR
branch/v13 Create PR

This was referenced Apr 28, 2023
Merged
Merged
Merged
@stevenGravy stevenGravy mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espadolini espadolini espadolini approved these changes

@greedy52 greedy52 greedy52 approved these changes

Assignees
No one assigned
Labels
backport/branch/v13 terraform Legacy Terraform label test-plan-problem Issues which have been surfaced by running the manual release test plan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugoShaka @espadolini @greedy52