Add buf breaking to the CI linter
#26828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
force-pushed
the
espadolini/proto-unbreak/ci-master
branch
9 times, most recently
from
a112663
to
a7ba307
Compare
espadolini
force-pushed
the
espadolini/proto-unbreak/master
branch
2 times, most recently
from
97df3f1
to
2ebab3d
Compare
espadolini
force-pushed
the
espadolini/proto-unbreak/ci-master
branch
from
f7c0462
to
a23a6a3
Compare
espadolini
requested review from
klizhentas,
russjones,
r0mant and
zmb3
as code owners
tigrato
approved these changes
May 29, 2023
codingllama
approved these changes
May 29, 2023
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
rosstimothy
approved these changes
May 30, 2023
zmb3
approved these changes
May 30, 2023
|
@espadolini See the table below for backport results.
|
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs
buf breaking, a backwards compatibility check for protobufs, as part of the linting in CI.Breakage is checked from the head of the PR against the base and - in backports - from the tip of master against the head of the PR. This helps ensure that no incompatibilities can occur when adding or changing fields in the protobuf messages, and that no incompatibilities can be added while backporting said changes.
In addition, this PR adds a Makefile target
lint-breaking(alias ofprotos/breaking) to use for local development, to check compatibility against a specified ref defaulting toorigin/master.Contributes to #26688