[v13] Allow setting max_session_ttl from clusterauth preferences #28130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport
documentation
size/md
tsh
github-actions
bot
requested review from
codingllama,
espadolini,
mdwn,
r0mant and
zmb3
r0mant
approved these changes
Jun 22, 2023
|
There was a bug in the original PR, right? Should we avoid backporting this on its own and include the other fix in here too? |
Yeah, this now includes that backport |
ravicious
requested changes
Jun 23, 2023
There was a problem hiding this comment.
Preemptively blocking the merge in case #26824 (comment) turns out to be a bug.
ravicious
approved these changes
Jun 26, 2023
espadolini
approved these changes
Jun 26, 2023
Document `default_session_ttl` in the reference.
use default session ttl for `tctl auth sign` leave tctl alone
Make use of updateClientFromPingReponse
lxea
force-pushed
the
lxea/maxsessionttl-v13
branch
from
364809f
to
0c53992
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
(#28185) * Allow setting max_session_ttl from clusterauth preferences Document `default_session_ttl` in the reference. * Set the default session ttl in generateCert use default session ttl for `tctl auth sign` leave tctl alone * fix merge error * Fix wrong CertTTL the KeyTTL if its zero in teleterm Make use of updateClientFromPingReponse
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #26824 and #28138