Set the default session ttl in generateCert #28138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
reviewed
Jun 22, 2023
espadolini
approved these changes
Jun 22, 2023
kimlisa
approved these changes
Jun 22, 2023
use default session ttl for `tctl auth sign` leave tctl alone
lxea
force-pushed
the
lxea/defaultsessionttl-fix
branch
from
6c85cc0
to
da99d31
Compare
This was referenced Jun 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that was introduced in #26824 where the the default session ttl was not getting set by the auth server, and was only being setthe client as the check for setting the session ttl was aonly added to
GenerateOpenSSHCert