Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default session ttl in generateCert #28138

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Set the default session ttl in generateCert #28138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/auth/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2071,6 +2071,10 @@ func generateCert(a *Server, req certRequest, caType types.CertAuthType) (*proto
var sessionTTL time.Duration
var allowedLogins []string

if req.ttl == 0 {
req.ttl = time.Duration(authPref.GetDefaultSessionTTL())
}

// If the role TTL is ignored, do not restrict session TTL and allowed logins.
// The only caller setting this parameter should be "tctl auth sign".
// Otherwise, set the session TTL to the smallest of all roles and
Expand Down