DeployService: auto upsert IAM Join Token #28537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
force-pushed
the
marco/deployservice_iam_token
branch
2 times, most recently
from
89567fd
to
cc3c2e3
Compare
1 task
marcoandredinis
force-pushed
the
marco/deployservice_iam_token
branch
4 times, most recently
from
24eac22
to
7a8dc4d
Compare
tigrato
reviewed
Jul 5, 2023
marcoandredinis
force-pushed
the
marco/deployservice_iam_token
branch
from
7a8dc4d
to
82a3366
Compare
marcoandredinis
force-pushed
the
marco/deployservice_iam_token
branch
from
82a3366
to
f29d218
Compare
tigrato
approved these changes
Jul 6, 2023
marcoandredinis
added
discover
When using the DeployService, the deployed services (database service only for now) will join the Teleport Cluster using the IAM Join Method. In order to do so, we require an IAM Token that allows the AWS Account ID and ARN of the assumed-role. Instead of asking the user to create it, we do it for them. This PR creates or updates the IAM Join Token.
marcoandredinis
force-pushed
the
marco/deployservice_iam_token
branch
from
f29d218
to
04d7338
Compare
jakule
approved these changes
Jul 6, 2023
| } | ||
|
|
||
| token, err := clt.GetToken(ctx, req.tokenName) | ||
| switch { |
There was a problem hiding this comment.
IMO in this case switch makes the flow very weird. My proposal
if trace.IsNotFound(err) {
token = ....
err = nil
}
if err != nil {
return trace.Wrap(err)
}
...There was a problem hiding this comment.
It's a bit complex because it has the fallthrough down below
I could switch to a plain if condition.
Given that you approve, I'll merge as is
But feel free to comment again and I'll try to simplify this part
|
@marcoandredinis See the table below for backport results.
|
ravicious
pushed a commit
that referenced
this pull request
Jul 11, 2023
* DeployService: auto upsert IAM Join Token When using the DeployService, the deployed services (database service only for now) will join the Teleport Cluster using the IAM Join Method. In order to do so, we require an IAM Token that allows the AWS Account ID and ARN of the assumed-role. Instead of asking the user to create it, we do it for them. This PR creates or updates the IAM Join Token. * AccountID is optional when calling DeployService * dry code when upserting the token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the DeployService, the deployed services (database service only for now) will join the Teleport Cluster using the IAM Join Method.
In order to do so, we require an IAM Token that allows the AWS Account ID and ARN of the assumed-role.
Instead of asking the user to create it, we do it for them.
This PR creates or updates the IAM Join Token.
Token created before deploying the service: