WebDiscover: Finish auto deploy screen (iam configure script) #28621

kimlisa · 2023-07-03T23:24:15Z

do not merge until the following has merged:

Script to configure IAM for the DeployService #28436
DeployService: auto upsert IAM Join Token #28537
DeployService IAM Configure: unescape arguments #28807
tested flow without problems

This pr:

enables the auto deploy flow
defines the script endpoint
emit events that differentiates between manual and auto deploy
previously, we were passing around integration.name but now we pass around the full object because we also need to access the roleArn for the cfg script

kimlisa · 2023-07-06T06:26:41Z

friendly ping @ryanclark @ibeckermayer

ibeckermayer · 2023-07-07T01:02:32Z

web/packages/teleport/src/Discover/useDiscover.tsx


-    updateAgentMeta({ integrationName } as DbMeta);
+    updateAgentMeta({ integration } as DbMeta);


The type system isn't complaining but this cast doesn't seem like it should work without making db and selectedAwsRdsDb optional.

export type DbMeta = BaseMeta & { // TODO(lisa): when we can enroll multiple RDS's, turn this into an array? // The enroll event expects num count of enrolled RDS's, update accordingly. db?: Database; integration?: Integration; selectedAwsRdsDb?: AwsRdsDatabase; // serviceDeployedMethod flag will be undefined if user skipped // deploying service (service already existed). serviceDeployedMethod?: ServiceDeployMethod; };

ibeckermayer · 2023-07-07T01:08:27Z

web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/AutoDeploy.tsx

+        toolTipContent={`Amazon Resource Names (ARNs) uniquely identifies AWS \
+        resources, in this case you will be naming an IAM role that this \
+        deployed service will be using`}


Not sure if this is exactly correct

Suggested change

toolTipContent={`Amazon Resource Names (ARNs) uniquely identifies AWS \

resources, in this case you will be naming an IAM role that this \

deployed service will be using`}

toolTipContent={`Amazon Resource Names (ARNs) uniquely identify AWS \

resources. In this case you will be giving an ARN to the IAM role that this \

deployed service will be using`}

If not then

Suggested change

toolTipContent={`Amazon Resource Names (ARNs) uniquely identifies AWS \

resources, in this case you will be naming an IAM role that this \

deployed service will be using`}

toolTipContent={`Amazon Resource Names (ARNs) uniquely identify AWS \

resources. In this case you will naming an IAM role that this \

deployed service will be using`}

ibeckermayer · 2023-07-07T01:11:23Z

web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/AutoDeploy.tsx

+        You will only need to do this once for all databases per geographical
+        region. <br />


Suggested change

You will only need to do this once for all databases per geographical

region. <br />

You will only need to do this once per geographical region.<br />

ibeckermayer · 2023-07-07T01:13:07Z

web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/AutoDeploy.test.tsx

+        <FeaturesContextProvider value={[]}>
+          <DiscoverProvider mockCtx={discoverCtx}>
+            <PingTeleportProvider
+              interval={TEST_PING_INTERVAL}


Will this actually try to ping something?

no, the test is too short (default was like 3 seconds), though i added a success state testing that will hit it once

web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/AutoDeploy.tsx

public-teleport-github-review-bot · 2023-07-10T15:28:13Z

@kimlisa See the table below for backport results.

Branch	Result
branch/v13	Failed

* Define the return type * Add endpoint for config script * Store the entire integration object instead of just the name * Build the correct script string, renames, emit event * Enable auto deploy as default * Fix script endpoint and update story * Add regex check, update story * Touch ups, add test * Address CR * Remove sudo from bash command * Make into ui friendly object

…ondition (#29978) * WebDiscover: Finish auto deploy screen (iam configure script) (#28621) * Define the return type * Add endpoint for config script * Store the entire integration object instead of just the name * Build the correct script string, renames, emit event * Enable auto deploy as default * Fix script endpoint and update story * Add regex check, update story * Touch ups, add test * Address CR * Remove sudo from bash command * Make into ui friendly object * [WebDiscover] Determine if IAM policy setup step can be skipped (#29724) * Prevent going back from access screen if deploying got skipped * Configuring perms for the user can take some time An error can return if a user tried to deploy before the changes are fully propagated. Notify the user that this can be a reason why an error returned and try again. * Check if IAM policy already configured with new dbs Clarify poller callback with comment Make IAMPolicy screen optional

kimlisa force-pushed the lisa/discover-auto-part-2 branch from a5bd10f to 7ebc9d9 Compare July 4, 2023 01:23

kimlisa marked this pull request as ready for review July 4, 2023 02:09

github-actions bot requested review from ibeckermayer and ravicious July 4, 2023 02:09

github-actions bot added size/sm ui labels Jul 4, 2023

kimlisa requested review from ryanclark and removed request for ravicious July 4, 2023 02:09

Base automatically changed from lisa/discover-auto-agent to master July 4, 2023 03:57

kimlisa force-pushed the lisa/discover-auto-part-2 branch 2 times, most recently from 2d52141 to 9814e87 Compare July 5, 2023 05:58

kimlisa force-pushed the lisa/discover-auto-part-2 branch from 9814e87 to e9efd92 Compare July 6, 2023 22:29

kimlisa added the backport/branch/v13 label Jul 6, 2023

ibeckermayer approved these changes Jul 7, 2023

View reviewed changes

ryanclark approved these changes Jul 7, 2023

View reviewed changes

marcoandredinis reviewed Jul 7, 2023

View reviewed changes

web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/AutoDeploy.tsx Outdated Show resolved Hide resolved

kimlisa force-pushed the lisa/discover-auto-part-2 branch from e406001 to 8e10e24 Compare July 10, 2023 14:48

kimlisa added 11 commits July 10, 2023 07:56

Define the return type

4c2af4e

Add endpoint for config script

814fdeb

Store the entire integration object instead of just the name

b3bffe1

Build the correct script string, renames, emit event

665a974

Enable auto deploy as default

5e9c261

Fix script endpoint and update story

f7c703e

Add regex check, update story

dd179cc

Touch ups, add test

3cc5dad

Address CR

f839ce3

Remove sudo from bash command

a718e7b

Make into ui friendly object

05600a0

kimlisa force-pushed the lisa/discover-auto-part-2 branch from c955ebe to 05600a0 Compare July 10, 2023 14:57

kimlisa added this pull request to the merge queue Jul 10, 2023

Merged via the queue into master with commit f693861 Jul 10, 2023
21 checks passed

kimlisa deleted the lisa/discover-auto-part-2 branch July 10, 2023 15:27

kimlisa mentioned this pull request Aug 3, 2023

[v13] WebDiscover: Enable auto deploy and skip IAM policy screen on condition #29978

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WebDiscover: Finish auto deploy screen (iam configure script) #28621

WebDiscover: Finish auto deploy screen (iam configure script) #28621

kimlisa commented Jul 3, 2023 •

edited

kimlisa commented Jul 6, 2023

ibeckermayer Jul 7, 2023

ibeckermayer Jul 7, 2023

ibeckermayer Jul 7, 2023

ibeckermayer Jul 7, 2023

kimlisa Jul 7, 2023 •

edited

public-teleport-github-review-bot bot commented Jul 10, 2023


		updateAgentMeta({ integrationName } as DbMeta);
		updateAgentMeta({ integration } as DbMeta);

		You will only need to do this once for all databases per geographical
		region. <br />

	You will only need to do this once for all databases per geographical
	region. <br />
	You will only need to do this once per geographical region.<br />

WebDiscover: Finish auto deploy screen (iam configure script) #28621

WebDiscover: Finish auto deploy screen (iam configure script) #28621

Conversation

kimlisa commented Jul 3, 2023 • edited

kimlisa commented Jul 6, 2023

ibeckermayer Jul 7, 2023

Choose a reason for hiding this comment

ibeckermayer Jul 7, 2023

Choose a reason for hiding this comment

ibeckermayer Jul 7, 2023

Choose a reason for hiding this comment

ibeckermayer Jul 7, 2023

Choose a reason for hiding this comment

kimlisa Jul 7, 2023 • edited

Choose a reason for hiding this comment

public-teleport-github-review-bot bot commented Jul 10, 2023

kimlisa commented Jul 3, 2023 •

edited

kimlisa Jul 7, 2023 •

edited