Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tctl: fix error reporting when server is down #29281

Merged
merged 1 commit into from
Jul 19, 2023
Merged

tctl: fix error reporting when server is down #29281

merged 1 commit into from
Jul 19, 2023

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Jul 18, 2023

A regresion in #25780 changed text that used to be reported to standard output to go to the logger instead. Since the logger output is only visible when the debug flag is set, this caused a fatal error to go unreported to the user.

Fixes #28129

@github-actions github-actions bot added size/sm tctl tctl - Teleport admin tool labels Jul 18, 2023
@zmb3
tctl: fix error reporting when server is down
8b35203 
A regresion in #25780 changed text that used to be reported to
standard output to go to the logger instead. Since the logger
output is only visible when the debug flag is set, this caused
a fatal error to go unreported to the user.

Fixes #28129
@zmb3 zmb3 enabled auto-merge July 19, 2023 17:24
@zmb3 zmb3 added this pull request to the merge queue Jul 19, 2023
Merged via the queue into master with commit bdcb7f4 Jul 19, 2023
21 checks passed
@zmb3 zmb3 deleted the zmb3/tctl-exit-fix branch July 19, 2023 18:00
@public-teleport-github-review-bot
Copy link

@zmb3 See the table below for backport results.

Branch Result
branch/v11 Failed
branch/v12 Failed
branch/v13 Create PR

@zmb3 zmb3 mentioned this pull request Jul 19, 2023
Merged
zmb3 added a commit that referenced this pull request Jul 19, 2023
@zmb3
tctl: fix error reporting when server is down (#29281)
49bd377 
A regresion in #25780 changed text that used to be reported to
standard output to go to the logger instead. Since the logger
output is only visible when the debug flag is set, this caused
a fatal error to go unreported to the user.

Fixes #28129
github-merge-queue bot pushed a commit that referenced this pull request Jul 19, 2023
@zmb3
tctl: fix error reporting when server is down (#29281) (#29324)
c9b322d 
A regresion in #25780 changed text that used to be reported to
standard output to go to the logger instead. Since the logger
output is only visible when the debug flag is set, this caused
a fatal error to go unreported to the user.

Fixes #28129
github-actions bot pushed a commit that referenced this pull request Jul 19, 2023
@zmb3
tctl: fix error reporting when server is down (#29281)
571402f 
A regresion in #25780 changed text that used to be reported to
standard output to go to the logger instead. Since the logger
output is only visible when the debug flag is set, this caused
a fatal error to go unreported to the user.

Fixes #28129
@zmb3 zmb3 mentioned this pull request Jul 20, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 20, 2023
@zmb3
tctl: fix error reporting when server is down (#29281) (#29329)
2049651 
A regresion in #25780 changed text that used to be reported to
standard output to go to the logger instead. Since the logger
output is only visible when the debug flag is set, this caused
a fatal error to go unreported to the user.

Fixes #28129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyinghermit flyinghermit flyinghermit approved these changes

@fspmarshall fspmarshall fspmarshall approved these changes

Assignees
No one assigned
Labels
backport/branch/v13 size/sm tctl tctl - Teleport admin tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tctl silently exits when the server is down
3 participants
@zmb3 @flyinghermit @fspmarshall