Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13] tctl: fix error reporting when server is down #29322

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[v13] tctl: fix error reporting when server is down #29322

merged 1 commit into from
Jul 20, 2023

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Jul 19, 2023

Backport #29281 to branch/v13

@zmb3
tctl: fix error reporting when server is down
76ad093 
A regresion in #25780 changed text that used to be reported to
standard output to go to the logger instead. Since the logger
output is only visible when the debug flag is set, this caused
a fatal error to go unreported to the user.

Fixes #28129
@github-actions github-actions bot added backport size/sm tctl tctl - Teleport admin tool labels Jul 19, 2023
@zmb3 zmb3 requested a review from jakule July 19, 2023 20:52
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from jakule July 19, 2023 22:14
@zmb3 zmb3 added this pull request to the merge queue Jul 20, 2023
Merged via the queue into branch/v13 with commit 8086784 Jul 20, 2023
21 checks passed
@zmb3 zmb3 deleted the bot/backport-29281-branch/v13 branch July 20, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyinghermit flyinghermit flyinghermit approved these changes

@GavinFrazar GavinFrazar GavinFrazar approved these changes

@fspmarshall fspmarshall fspmarshall approved these changes

Assignees
No one assigned
Labels
backport size/sm tctl tctl - Teleport admin tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zmb3 @flyinghermit @GavinFrazar @fspmarshall