Remove dependency of etcd from tctl #29377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following import tree resulted in tctl importing etcd: | github.com/gravitational/teleport/tool/tctl |--> github.com/gravitational/teleport/tool/tctl/common |---> github.com/gravitational/teleport/lib/auth |----> github.com/gravitational/teleport/lib/auth/okta |-----> github.com/gravitational/teleport/lib/services/local |-------> github.com/gravitational/teleport/lib/backend/etcdbk |--------> go.etcd.io/etcd/client/v3 This stems from the assistant service which checks if the backend is etcd by using type assertion. A new GetName method is added to backend.Backend so that the storage mechanism can be determined via string comparison instead of importing backend implementations to do type assertion.
rosstimothy
force-pushed
the
tross/remove_etcd_dep_from_tctl
branch
from
82177fb
to
685c28e
Compare
zmb3
approved these changes
Jul 20, 2023
GavinFrazar
approved these changes
Jul 20, 2023
public-teleport-github-review-bot
bot
removed the request for review
from r0mant
rosstimothy
added a commit
that referenced
this pull request
Jul 21, 2023
The following import tree resulted in tctl importing etcd: | github.com/gravitational/teleport/tool/tctl |--> github.com/gravitational/teleport/tool/tctl/common |---> github.com/gravitational/teleport/lib/auth |----> github.com/gravitational/teleport/lib/auth/okta |-----> github.com/gravitational/teleport/lib/services/local |-------> github.com/gravitational/teleport/lib/backend/etcdbk |--------> go.etcd.io/etcd/client/v3 This stems from the assistant service which checks if the backend is etcd by using type assertion. A new GetName method is added to backend.Backend so that the storage mechanism can be determined via string comparison instead of importing backend implementations to do type assertion.
rosstimothy
added a commit
that referenced
this pull request
Jul 21, 2023
The following import tree resulted in tctl importing etcd: | github.com/gravitational/teleport/tool/tctl |--> github.com/gravitational/teleport/tool/tctl/common |---> github.com/gravitational/teleport/lib/auth |----> github.com/gravitational/teleport/lib/auth/okta |-----> github.com/gravitational/teleport/lib/services/local |-------> github.com/gravitational/teleport/lib/backend/etcdbk |--------> go.etcd.io/etcd/client/v3 This stems from the assistant service which checks if the backend is etcd by using type assertion. A new GetName method is added to backend.Backend so that the storage mechanism can be determined via string comparison instead of importing backend implementations to do type assertion.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
The following import tree resulted in tctl importing etcd: | github.com/gravitational/teleport/tool/tctl |--> github.com/gravitational/teleport/tool/tctl/common |---> github.com/gravitational/teleport/lib/auth |----> github.com/gravitational/teleport/lib/auth/okta |-----> github.com/gravitational/teleport/lib/services/local |-------> github.com/gravitational/teleport/lib/backend/etcdbk |--------> go.etcd.io/etcd/client/v3 This stems from the assistant service which checks if the backend is etcd by using type assertion. A new GetName method is added to backend.Backend so that the storage mechanism can be determined via string comparison instead of importing backend implementations to do type assertion.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
The following import tree resulted in tctl importing etcd: | github.com/gravitational/teleport/tool/tctl |--> github.com/gravitational/teleport/tool/tctl/common |---> github.com/gravitational/teleport/lib/auth |----> github.com/gravitational/teleport/lib/auth/okta |-----> github.com/gravitational/teleport/lib/services/local |-------> github.com/gravitational/teleport/lib/backend/etcdbk |--------> go.etcd.io/etcd/client/v3 This stems from the assistant service which checks if the backend is etcd by using type assertion. A new GetName method is added to backend.Backend so that the storage mechanism can be determined via string comparison instead of importing backend implementations to do type assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following import tree resulted in tctl depending on etcd:
This stems from the assistant service which checks if the backend is etcd by using type assertion. A new GetName method is added to backend.Backend so that the storage mechanism can be determined via string comparison instead of importing backend implementations to do type assertion.