Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12] Remove dependency of etcd from tctl #29395

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

rosstimothy
Copy link
Contributor

Backport #29377 to branch/v12

The following import tree resulted in tctl importing etcd:

| github.com/gravitational/teleport/tool/tctl
|--> github.com/gravitational/teleport/tool/tctl/common
|---> github.com/gravitational/teleport/lib/auth
|----> github.com/gravitational/teleport/lib/auth/okta
|-----> github.com/gravitational/teleport/lib/services/local
|-------> github.com/gravitational/teleport/lib/backend/etcdbk
|--------> go.etcd.io/etcd/client/v3

This stems from the assistant service which checks if the backend
is etcd by using type assertion. A new GetName method is added
to backend.Backend so that the storage mechanism can be determined
via string comparison instead of importing backend implementations
to do type assertion.
@rosstimothy rosstimothy marked this pull request as ready for review July 21, 2023 13:18
@rosstimothy rosstimothy added this pull request to the merge queue Jul 21, 2023
Merged via the queue into branch/v12 with commit 5f02abd Jul 21, 2023
20 checks passed
@rosstimothy rosstimothy deleted the tross/backport-29377/v12 branch July 21, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants