[v13] Embedded Assist SSH #30811
Merged
[v13] Embedded Assist SSH #30811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tunistic node lookup (#29716) * assist: extract embedding types into a dedicated module * assist: allow the embedding tool to query nodes from proxy cache This commit does two things: - Introduce a new toolsConfig structure to pass all required clients to the tools. This can also be used to enable or disable specicifc tools, which helps with testing - Pass the proxy node cache and the request access checker to the embedding tool so it can try to lookup nodes from cache in if the user has less than 10 nodes available. * Add tests for the opportunistic proxy node lookup * Apply suggestions from code review * Update lib/ai/client.go
* Add Assist to the terminal UI * Use getPlatform() * Fix spacing beneath the message box
* Add in SSH context Assist endpoints This change introduces web endpoints used by Assist to support in SSH context functionality in the WebUI. Now a user will be able to generate Bash command and explain output in the terminal (like application logs). * Remove mockup web UI * Make the linter happy * Remove unnecessary comments and add missing documentation This commit removes a redundant comment on the AI model selection in client.go that suggested a model change that is not needed. It also adds missing documentation in chat.go, to clarify the purpose and functionality of the Reply function. * Revert ws.WriteControl to use real time. Usage of the fake clock was failing the tests, and it's not really beneficial in this case.
The caret symbol (^) previously used in the Terminal utility was not universally recognized or understanding. To increase usability, it has been replaced with the Windows key symbol (⊞). This should make the tool more intuitive to use for a wider range of users.
…ting (#30513) * Add AssistAction and AssistAccessRequest PostHog event reporting This commit introduced new usage tracking for Assist features. AssistAction event is emitted when user triggers an action like SSH command generation or output explaining. AssistAccessRequest event is fired when user requests access to a resource. The events capture anonymized username, resource type or action triggered, and a breakdown of tokens used for generating command summaries or completion responses. * "Removed userName in AssistAccessRequest and AssistAction" Both "AssistAccessRequest" and "AssistAction" messages in usageevents.proto file and their corresponding Go structures were modified to remove the "userName" field. * Add GoDoc
|
@jakule - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
r0mant
approved these changes
Aug 22, 2023
hugoShaka
approved these changes
Aug 22, 2023
public-teleport-github-review-bot
bot
removed the request for review
from avatus
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of SSH Embedded AI to v13 related PRs:
#30513
#30642
#30319
#30496
#29716