-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 13.3.5 #30832
Release 13.3.5 #30832
Conversation
* Added `--current-device` capabilities to `tsh`. [#30702](https://github.com/gravitational/teleport/pull/30702) | ||
* Fixed Review Requests to disallow reviews after request is resolved. [#30690](https://github.com/gravitational/teleport/pull/30690) | ||
* Fixed Teleport Connect to properly show errors from the remote end. [#30684](https://github.com/gravitational/teleport/pull/30684) | ||
* Fixed an issue with `tsh aws ssm start-session`. [#30668](https://github.com/gravitational/teleport/pull/30668) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@greedy52 can you suggest a better description than "fixed an issue" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't work before. Maybe?
- Fixed an issue
tsh aws ssm start-session
fails with an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to figure out a better description for this one but I didn't know how to describe "endpoint URL mode" concisely and usefully.
@jentfoo did you purposely push changes to this branch? In most cases, the release commit only updates versions and the changelog. Is there any reason your fuzzing changes can't be backported in the typical manner? Edit: I see this was the |
This expands the coverage of fuzzing in `lib/web/fuzz_test.go` and includes adding seeds. From this work a new panic was discovered where a pointer is allocated then a pointer to the pointer is passed into json.Unmarshal. It is then possible for this original pointer to remain a `nil` reference. This pattern looks unexpected, so all cases of double pointers being passed into json.Unmarshal were changed to the more standard empty struct pointer style to avoid potential nil reference panics.
a1864d9
to
c5e5e89
Compare
tsh
to register and enroll the--current-device
. #30702tsh aws ssm start-session
. #30668invalid maxDuration
. teleport.e#2037Security fix
medium
severity DoS conditions through protocol level attacks. #30854