Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFA Fuzzing and Json.Unmarshal Panic fix #30854

Merged
merged 1 commit into from
Aug 22, 2023
Merged

MFA Fuzzing and Json.Unmarshal Panic fix #30854

merged 1 commit into from
Aug 22, 2023

Commits on Aug 22, 2023

  1. MFA Fuzzing and Json Unmarshal Panic fix 

    This expands the coverage of fuzzing in `lib/web/fuzz_test.go` and includes adding seeds.
From this work a new panic was discovered where a pointer is allocated then a pointer to the pointer is passed into json.Unmarshal.  It is then possible for this original pointer to remain a `nil` reference.

This pattern looks unexpected, so all cases of double pointers being passed into json.Unmarshal were changed to the more standard empty struct pointer style to avoid potential nil reference panics.
    @jentfoo
    jentfoo committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f0ec109 View commit details
    Browse the repository at this point in the history