MFA Fuzzing and Json.Unmarshal Panic fix #30854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expands the coverage of fuzzing in `lib/web/fuzz_test.go` and includes adding seeds. From this work a new panic was discovered where a pointer is allocated then a pointer to the pointer is passed into json.Unmarshal. It is then possible for this original pointer to remain a `nil` reference. This pattern looks unexpected, so all cases of double pointers being passed into json.Unmarshal were changed to the more standard empty struct pointer style to avoid potential nil reference panics.
jentfoo
requested review from
Tener,
zmb3 and
codingllama
and removed request for
jimbishopp
r0mant
approved these changes
Aug 22, 2023
zmb3
approved these changes
Aug 22, 2023
public-teleport-github-review-bot
bot
removed request for
jakule,
Joerger,
rosstimothy,
Tener and
codingllama
This was referenced Aug 22, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the coverage of fuzzing in
lib/web/fuzz_test.goand includes adding seeds. From this work a new panic was discovered where a pointer is allocated then a pointer to the pointer is passed intojson.Unmarshal. It is then possible for this original pointer to remain anilreference.This pattern looks unexpected, so all cases of double pointers being passed into
json.Unmarshalwere changed to the more standard empty struct pointer style to avoid potential nil reference panics.Originally opened in this PR: https://github.com/gravitational/teleport-private/pull/891 but severity was deemed low enough to fix directly in OSS
Backporting will be done through release PR's already open: