Always prefer multiplex port if Kube Proxy endpoint is specified #34211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
bot
added
size/sm
tsh
Tener
approved these changes
Nov 6, 2023
AntonAM
approved these changes
Nov 7, 2023
|
@hugoShaka friendly ping! |
hugoShaka
approved these changes
Dec 4, 2023
This was referenced Dec 4, 2023
tigrato
added a commit
that referenced
this pull request
Dec 11, 2023
This PR fixes a regression introduced by #34211 where the Kube server address was using the incorrect port when doing `tsh kube login`. Changelog: Fixes regression of Kubernetes Server Address when Teleport runs in multiplex mode. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Fix regression in Kube Address introduced by #34211 This PR fixes a regression introduced by #34211 where the Kube server address was using the incorrect port when doing `tsh kube login`. Changelog: Fixes regression of Kubernetes Server Address when Teleport runs in multiplex mode. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Update tool/tsh/common/kube_test.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
This PR fixes a regression introduced by #34211 where the Kube server address was using the incorrect port when doing `tsh kube login`. Changelog: Fixes regression of Kubernetes Server Address when Teleport runs in multiplex mode. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this pull request
Dec 11, 2023
* Fix regression in Kube Address introduced by #34211 This PR fixes a regression introduced by #34211 where the Kube server address was using the incorrect port when doing `tsh kube login`. Changelog: Fixes regression of Kubernetes Server Address when Teleport runs in multiplex mode. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Update tool/tsh/common/kube_test.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Fix regression in Kube Address introduced by #34211 This PR fixes a regression introduced by #34211 where the Kube server address was using the incorrect port when doing `tsh kube login`. Changelog: Fixes regression of Kubernetes Server Address when Teleport runs in multiplex mode. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Update tool/tsh/common/kube_test.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Fix regression in Kube Address introduced by #34211 This PR fixes a regression introduced by #34211 where the Kube server address was using the incorrect port when doing `tsh kube login`. Changelog: Fixes regression of Kubernetes Server Address when Teleport runs in multiplex mode. * Update tool/tsh/common/kube_test.go --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default behavior of
tsh login -f kubeconfig -o ./kubeconfig --kube-cluster <kube_cluster>to prefer the multiplex port instead of the Kubernetes public address if specified.Changelog: Always prefer multiplex port for Kubernetes Access