[v13] Fix regression in Kube Address introduced by #34211 #35634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix regression in Kube Address introduced by #34211 This PR fixes a regression introduced by #34211 where the Kube server address was using the incorrect port when doing `tsh kube login`. Changelog: Fixes regression of Kubernetes Server Address when Teleport runs in multiplex mode. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Update tool/tsh/common/kube_test.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-actions
bot
added
backport
size/sm
tsh
AntonAM
approved these changes
Dec 11, 2023
|
@zmb3 can you please add |
rosstimothy
approved these changes
Dec 11, 2023
public-teleport-github-review-bot
bot
removed request for
ravicious and
gabrielcorado
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #35623 to branch/v13
changelog: Fixed regression of Kubernetes Server Address when Teleport runs in multiplex mode.