Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14] Add access lists, members, and reviews to cache. #36331

Merged
merged 3 commits into from Jan 9, 2024
Merged

[v14] Add access lists, members, and reviews to cache. #36331

merged 3 commits into from Jan 9, 2024

Commits on Jan 5, 2024

  1. Add access lists, members, and reviews to cache. 

    Access lists, members, and reviews have been added to the cache. To do this,
I have created a simple backend that doesn't perform the validation that is
performed by the main access list backend and only implements a subset of
actions that are needed by the cache.

To support this, I've added in new gRPC methods:
ListAllAccessListMembers and ListAllAccessListReviews. These do not lock
any access lists and additionally do not perform any implicit or dynamic
members, but just simply return the full list of all members and reviews
so that these endpoints can be used to populate the cache.

The general thought here that, since the order of cache events cannot be
guaranteed, we'll rely on the auth server to perform the proper backend
validation and use a simplified backend that simply sees if the items
are present in the cache. If so, we'll return them.

I've had to update a few protos to support this. While I was here, I
fixed a bug in the access list gRPC client where the call tolist of reviews
was not supplying the access list name. Additionally, the user login
state generator will now use the cached access list values.
    @mdwn
    mdwn authored and github-actions committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    4446c48 View commit details
    Browse the repository at this point in the history

  2. Move simple backend to lib/services/simple

    @mdwn
    mdwn authored and github-actions committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    676939e View commit details
    Browse the repository at this point in the history

  3. Update to reflect new generic function signatures.

    @mdwn
    mdwn authored and github-actions committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    3687e1c View commit details
    Browse the repository at this point in the history