Add support for dynamic token providers in kubeconfig used by the proxy #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 30, 2020 13:25
By importing the magic `k8s.io/client-go/plugin/pkg/client/auth` package, we compile-in support for auth plugins: gcp, azure, oidc, openstack. Without this, users can't provide a kubeconfig using those authn methods to a proxy.
TargetAddr from ForwarderConfig wasn't actually ever used. Kubeconfig parsing would fail if server address was missing.
The existing kubeCreds already has tls.Config. Add a new wrapTransport method to it, which handles added bearer tokens or basic auth to the request before it goes out. Use this wrapTransport to inject tokens for both SPDY connections and catch-all forwarder requests. Also simplify a few unrelated parts: - don't manually call serverName verification in SPDY dialer - have requestCertificate return a finished tls.Config instead of an intermediate type
These are no longer needed.
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
russjones
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic tokens (as opposed to static,
cfg.BearerToken) require usinghttp.RoundTripperwrappers provided by the k8s libraries.To do this, make a
kubeCreds.wrapTransportmethod that does wrapping the right way and use it with both SPDY dialer and regular HTTP forwarder.Practically, this means the proxy can now talk to GCP, Azure and AWS k8s clusters using their plugin-based kubeconfigs.
It'll also support any other exec plugin a user might specify.
Also bundle a few semi-related changes (to avoid conflicting PRs):
ForwarderConfig.TargetAddr- it was never set explicitly and kubeconfig should be the authoritative source anywayrequestCertificatereturn a finishedtls.Configinstead of an intermediate typekubeCredsintoauth.goServerNameFixes #3652