Login form UI redesign #39883
Merged
Login form UI redesign #39883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl-nero
force-pushed
the
bl-nero/login-dialog
branch
from
8f18f7e
to
af38b22
Compare
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
 Failed |
Vulnerabilities | 3 1 0 0 |
View in Orca |
☢️ The following Vulnerabilities (CVEs) have been detected
| PACKAGE | FILE | CVE ID | INSTALLED VERSION | FIXED VERSION | ||
|---|---|---|---|---|---|---|
 |
minimist | ./yarn.lock | CVE-2021-44906 | 0.0.10 | 1.2.6, 0.2.4 | View in code |
|
d3-color | ./yarn.lock | GHSA-36jr-mh4h-2g58 | 2.0.0 | 3.1.0 | View in code |
|
trim | ./yarn.lock | CVE-2020-7753 | 0.0.1 | 0.0.3 | View in code |
|
trim-newlines | ./yarn.lock | CVE-2021-33623 | 1.0.0 | 3.0.1, 4.0.1 | View in code |
|
Ok, looks like all that yarn.lock mess was just my local Yarn going crazy and installing stuff all over the place; it's OK now. |
rudream
reviewed
Apr 2, 2024
ryanclark
approved these changes
Apr 4, 2024
rudream
approved these changes
Apr 5, 2024
|
Tested:
|
ravicious
reviewed
Apr 9, 2024
Comment on lines
+3490
to
3505
| "@testing-library/dom@>=7": | ||
| version "9.3.4" | ||
| resolved "https://registry.yarnpkg.com/@testing-library/dom/-/dom-9.3.4.tgz#50696ec28376926fec0a1bf87d9dbac5e27f60ce" | ||
| integrity sha512-FlS4ZWlp97iiNWig0Muq8p+3rVDjRiYE+YKGbAqXOu9nwJFFOdL00kFpz42M+4huzYi86vAK1sOOfyOG45muIQ== | ||
| dependencies: | ||
| "@babel/code-frame" "^7.10.4" | ||
| "@babel/runtime" "^7.12.5" | ||
| "@types/aria-query" "^5.0.1" | ||
| aria-query "5.1.3" | ||
| chalk "^4.1.0" | ||
| dom-accessibility-api "^0.5.9" | ||
| lz-string "^1.5.0" | ||
| pretty-format "^27.0.2" | ||
|
|
||
| "@testing-library/dom@^9.0.0": | ||
| version "9.3.3" |
There was a problem hiding this comment.
This results in the wrong @testing-library/dom being resolved by yarn which then causes a ton of act warnings in tests, see #33356 and a slack thread from the previous time this has happened.
I'll post a PR which fixes that soon.
There was a problem hiding this comment.
@ravicious Thanks, I wasn't aware of this issue.
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: I used a new library in the test (
react-select-event), and installing it apparently made Lint explode, pulled in a ton of spurious deps, and triggered a vulnerability check. I'll deal with it once I'm back from vacation next week, but the rest of the code is ready for review.Closes #36234
Demo: https://www.loom.com/share/93edb868557246afba63d76c2469662c?sid=2e596480-4845-48c8-8869-98d673dd285a
Tested:
Changelog: Redesigned the login UI.