[v15] Web: Make s3 fields optional #40368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added splitAwsIamArn helper that splits account id and its arn parts - Require running a new script per change of each editable fields (includes roleArn) - fix test to not emit "wrap with act" warning
rudream
approved these changes
Apr 9, 2024
avatus
approved these changes
Apr 9, 2024
kimlisa
force-pushed
the
bot/backport-40145-branch/v15
branch
from
bd17775
to
58da212
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #40145 to branch/v15
changelog: Amazon S3 fields are now optional when creating or editing AWS OIDC integration on the web UI