Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v15] Web: Make s3 fields optional #40368

Merged
merged 10 commits into from Apr 9, 2024
Merged

[v15] Web: Make s3 fields optional #40368

merged 10 commits into from Apr 9, 2024

Commits on Apr 9, 2024

  1. Add outline-warn to alert banners

    @kimlisa
    kimlisa authored and github-actions committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    20ba899 View commit details
    Browse the repository at this point in the history

  2. Conditionally add s3 fields when generating script

    @kimlisa
    kimlisa authored and github-actions committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    57fa02f View commit details
    Browse the repository at this point in the history

  3. Allow s3 fields rules to ignore empty input conditionally

    @kimlisa
    kimlisa authored and github-actions committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    51b98de View commit details
    Browse the repository at this point in the history

  4. Add hover tooltip for aws rows without s3 fields

    @kimlisa
    kimlisa authored and github-actions committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    07a6d47 View commit details
    Browse the repository at this point in the history

  5. Show warning if user does not provide s3 fields when creating integra… 

    …tion
    @kimlisa
    kimlisa authored and github-actions committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    31c1c56 View commit details
    Browse the repository at this point in the history

  6. Show warning if user leaves s3 bucket fields empty when editing integ… 

    …ration
    @kimlisa
    kimlisa authored and github-actions committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    7be553f View commit details
    Browse the repository at this point in the history

  7. Don't prefill if input is empty

    @kimlisa
    kimlisa authored and github-actions committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    cc24b85 View commit details
    Browse the repository at this point in the history

  8. Final touches 

    - Added splitAwsIamArn helper that splits account id and its arn parts
- Require running a new script per change of each editable fields
  (includes roleArn)
- fix test to not emit "wrap with act" warning
    @kimlisa
    kimlisa authored and github-actions committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    46c0c61 View commit details
    Browse the repository at this point in the history

  9. fix license lint

    @kimlisa
    kimlisa committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    58da212 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'branch/v15' into bot/backport-40145-branch/v15

    @kimlisa
    kimlisa committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    611bd28 View commit details
    Browse the repository at this point in the history