fix kube ephemeral container test flakiness #40871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Failed |
Infrastructure as Code |  1  2  1  1 |
View in Orca |
 Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Controller of pods with role that allows the creation or modification of other pods | ...bac/ci-teleport.yaml | View in code |
|
Controller of pods with role that allows attaching or executing commands inside a pod | ...bac/ci-teleport.yaml | View in code |
|
RBAC Roles with Port-Forwarding Permission | ...bac/ci-teleport.yaml | View in code |
|
Controller of pods with impersonation privileges service account | ...bac/ci-teleport.yaml | View in code |
|
Ensure Administrative Boundaries Between Resources | ...bac/ci-teleport.yaml | View in code |
capnspacehook
added
the
no-changelog
probakowski
approved these changes
Apr 24, 2024
Joerger
approved these changes
Apr 25, 2024
public-teleport-github-review-bot
bot
removed the request for review
from AntonAM
capnspacehook
added a commit
that referenced
this pull request
Apr 25, 2024
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes backend expects clients to always have Stdout, Stderr, and Stdin set when executing in/attaching to a container, and not setting these would sometimes panic and cause the test to hang. While fixing this I added another check to test that an ephemeral container is only created once moderated session requirements have been met.
Fixes #40850.