[v15] fix k8s moderated sessions bypass with ephemeral containers #40906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rebase with master * only retrieve logs on a specific error * fix cache test again and a linter issue * only look for ephemeral container name when waiting for the container to start * address feedback * add support for other merge strategies * handle case * reorganize gomod * address feedback * fix missing patchtype * propagate errors * Update lib/kube/proxy/sess.go Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> * add hint of exec process into session tracker * address feedback * optionally filter listed waiting conts server-side * add TODO to test against tsh kubectl * Revert "optionally filter listed waiting conts server-side" This reverts commit 9a33868363e427f52bba8d95ead2bfc0d939e6e7. * fix failing integration test, undo accidental dep update --------- Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
capnspacehook
force-pushed
the
capnspacehook/backport/v15/40792
branch
from
d729afc
to
164c974
Compare
r0mant
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
@capnspacehook Let's please make sure to verify the backport (even if it was a clean one).
|
Manually tested and everything works correctly. |
tigrato
approved these changes
Apr 26, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rosstimothy
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of #40792 and #40871.
changelog: properly enforce session moderation requirements when starting Kubernetes ephemeral containers