fix: Emit login failure event in the /mfa/login/begin step #41419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
May 10, 2024
rosstimothy
approved these changes
May 10, 2024
|
@codingllama See the table below for backport results.
|
This was referenced May 10, 2024
codingllama
added a commit
that referenced
this pull request
May 10, 2024
* Test failed user/pass audit on CreateAuthenticateChallenge * Emit login failure event in the /mfa/login/begin step * nit: Remove final stop from logging statements * nit: Remove seemingly outdated comment
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
) * fix: Emit login failure event in the /mfa/login/begin step (#41419) * Test failed user/pass audit on CreateAuthenticateChallenge * Emit login failure event in the /mfa/login/begin step * nit: Remove final stop from logging statements * nit: Remove seemingly outdated comment * Apply fixes for branch/v13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit the "Local Login Failed" event if the user fails a password check on CreateAuthenticateChallenge, which previously was a silent failure. This puts password+webauthn login audit on par with password+otp (which skips CreateAuthenticateChallenge entirely).
This is the only missing audit event from #36837 that can be addressed. As stated above, password+otp failures are already covered. Tapping the incorrect key, as mentioned in the issues, causes only a client-side failure.
#36837
Changelog: Emit login login failed audit events for invalid passwords on password+webauthn local authentication.