[v14] Prevent web ui SSH connections from leaking #41519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/backport-41501/v14
branch
from
28031ca
to
8678485
Compare
The session closing in TerminalHandler.Close did not always close established ssh sessions if the client closed the web socket at any point between the new browser tab being opened and the session being established. In these cases the SSH connection was leaked for the duration of the Proxy process. To ensure sessions are always terminated a check to see if the client closed the web socket was added prior to writing the session metadata and after the shell is established for the ssh session.
rosstimothy
force-pushed
the
tross/backport-41501/v14
branch
from
8678485
to
30fdcf3
Compare
|
Tests were omitted from the backport due to changes in how the WS communication works in branch/v14. It was going to require rewriting a considerable amount of the terminal and test code to support the new test added in #41501. |
marcoandredinis
approved these changes
May 14, 2024
zmb3
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #41501 to branch/v14
Changelog: Prevent SSH connections opened in the UI from leaking if the browser tab is closed while the SSH connection is being established.