Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14] Prevent web ui SSH connections from leaking #41519

Merged
merged 1 commit into from
May 14, 2024
Merged

[v14] Prevent web ui SSH connections from leaking #41519

merged 1 commit into from
May 14, 2024

Commits on May 14, 2024

  1. Prevent web ui SSH connections from leaking (#41501) 

    The session closing in TerminalHandler.Close did not always close
established ssh sessions if the client closed the web socket
at any point between the new browser tab being opened and the session
being established. In these cases the SSH connection was leaked for
the duration of the Proxy process. To ensure sessions are always
terminated a check to see if the client closed the web socket was
added prior to writing the session metadata and after the shell
is established for the ssh session.
    @rosstimothy
    rosstimothy committed May 14, 2024
    Configuration menu
    Copy the full SHA
    30fdcf3 View commit details
    Browse the repository at this point in the history