-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host User Creation - update groups for existing users #41919
Conversation
Friendly ping @gabrielcorado @timothyb89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works, but just have a question that's (probably?) more about the historical implementation than your change. I'm happy to change to an approval if you think I'm off base or further changes are out of scope.
#40967 might have implications related to this PR. If we were to implement that other request, I imagine it would introduce additional cases to be considered by this code. |
a7a7724
to
f484777
Compare
Friendly ping @gabrielcorado |
This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role.
f484777
to
b788cc5
Compare
This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role.
This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role.
This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role.
* Update host user groups for existing users (#41919) This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role. * improve dynamodb permission error msg (#42855) * improve dynamodb permission error msg * Update lib/backend/dynamo/atomicwrite.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Fix GCP metadata errors crashing Teleport (#42696) * Web: Fix differing duration between unified resource and access request page (#42742) * Web: refactor and fix anti-pattern in access request * Update affected teleterm files * Address CR and fix updating duration should update pending * Fix test and stories * Reorganize Access Controls guides Move Access Controls giudes into References or Admin Guides, as appropriate. Also reorganizes the Admin Guides section to reduce the size of the table of contents page. --------- Co-authored-by: Andrew Burke <31974658+atburke@users.noreply.github.com> Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Lisa Kim <lisa@goteleport.com>
* Update host user groups for existing users (#41919) This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role. * improve dynamodb permission error msg (#42855) * improve dynamodb permission error msg * Update lib/backend/dynamo/atomicwrite.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Fix GCP metadata errors crashing Teleport (#42696) * Web: Fix differing duration between unified resource and access request page (#42742) * Web: refactor and fix anti-pattern in access request * Update affected teleterm files * Address CR and fix updating duration should update pending * Fix test and stories * Reorganize Access Controls guides Move Access Controls giudes into References or Admin Guides, as appropriate. Also reorganizes the Admin Guides section to reduce the size of the table of contents page. --------- Co-authored-by: Andrew Burke <31974658+atburke@users.noreply.github.com> Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Lisa Kim <lisa@goteleport.com>
This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role.
This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role.
This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role.
* Update host user groups for existing users (#41919) This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role. * improve dynamodb permission error msg (#42855) * improve dynamodb permission error msg * Update lib/backend/dynamo/atomicwrite.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Fix GCP metadata errors crashing Teleport (#42696) * Web: Fix differing duration between unified resource and access request page (#42742) * Web: refactor and fix anti-pattern in access request * Update affected teleterm files * Address CR and fix updating duration should update pending * Fix test and stories * Reorganize Access Controls guides Move Access Controls giudes into References or Admin Guides, as appropriate. Also reorganizes the Admin Guides section to reduce the size of the table of contents page. --------- Co-authored-by: Andrew Burke <31974658+atburke@users.noreply.github.com> Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Lisa Kim <lisa@goteleport.com>
This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if the groups were changed in the user's role.
Fixes #41178.
Changelog: Fixed updating groups for Teleport-created host users