Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve dynamodb permission error msg #42855

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

fspmarshall
Copy link
Contributor

v16+ has an additional dynamodb permission requirement. This PR attempts to make the error a bit friendlier, so that anyone who misses the changelog entry can get things fixed quickly.

@fspmarshall fspmarshall added backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry labels Jun 12, 2024
@github-actions github-actions bot requested review from camscale and jakule June 12, 2024 15:43
lib/backend/dynamo/atomicwrite.go Outdated Show resolved Hide resolved
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@fspmarshall fspmarshall added this pull request to the merge queue Jun 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2024
@fspmarshall fspmarshall added this pull request to the merge queue Jun 12, 2024
Merged via the queue into master with commit 808d96a Jun 12, 2024
38 checks passed
@fspmarshall fspmarshall deleted the fspmarshall/improve-dynamo-error-msg branch June 12, 2024 18:04
@public-teleport-github-review-bot

@fspmarshall See the table below for backport results.

Branch Result
branch/v16 Create PR

ptgott pushed a commit that referenced this pull request Jun 12, 2024
* improve dynamodb permission error msg

* Update lib/backend/dynamo/atomicwrite.go

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
ptgott added a commit that referenced this pull request Jun 12, 2024
* Update host user groups for existing users (#41919)

This change fixes a bug in host user creation where Teleport would not
update the groups of a returning user if groups were changed in
the user's role.

* improve dynamodb permission error msg (#42855)

* improve dynamodb permission error msg

* Update lib/backend/dynamo/atomicwrite.go

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

* Fix GCP metadata errors crashing Teleport (#42696)

* Web: Fix differing duration between unified resource and access request page (#42742)

* Web: refactor and fix anti-pattern in access request

* Update affected teleterm files

* Address CR and fix updating duration should update pending

* Fix test and stories

* Reorganize Access Controls guides

Move Access Controls giudes into References or Admin Guides, as
appropriate.

Also reorganizes the Admin Guides section to reduce the size of the
table of contents page.

---------

Co-authored-by: Andrew Burke <31974658+atburke@users.noreply.github.com>
Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Co-authored-by: Lisa Kim <lisa@goteleport.com>
ptgott added a commit that referenced this pull request Jun 12, 2024
* Update host user groups for existing users (#41919)

This change fixes a bug in host user creation where Teleport would not
update the groups of a returning user if groups were changed in
the user's role.

* improve dynamodb permission error msg (#42855)

* improve dynamodb permission error msg

* Update lib/backend/dynamo/atomicwrite.go

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

* Fix GCP metadata errors crashing Teleport (#42696)

* Web: Fix differing duration between unified resource and access request page (#42742)

* Web: refactor and fix anti-pattern in access request

* Update affected teleterm files

* Address CR and fix updating duration should update pending

* Fix test and stories

* Reorganize Access Controls guides

Move Access Controls giudes into References or Admin Guides, as
appropriate.

Also reorganizes the Admin Guides section to reduce the size of the
table of contents page.

---------

Co-authored-by: Andrew Burke <31974658+atburke@users.noreply.github.com>
Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Co-authored-by: Lisa Kim <lisa@goteleport.com>
ptgott added a commit that referenced this pull request Jun 17, 2024
* Update host user groups for existing users (#41919)

This change fixes a bug in host user creation where Teleport would not
update the groups of a returning user if groups were changed in
the user's role.

* improve dynamodb permission error msg (#42855)

* improve dynamodb permission error msg

* Update lib/backend/dynamo/atomicwrite.go

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

* Fix GCP metadata errors crashing Teleport (#42696)

* Web: Fix differing duration between unified resource and access request page (#42742)

* Web: refactor and fix anti-pattern in access request

* Update affected teleterm files

* Address CR and fix updating duration should update pending

* Fix test and stories

* Reorganize Access Controls guides

Move Access Controls giudes into References or Admin Guides, as
appropriate.

Also reorganizes the Admin Guides section to reduce the size of the
table of contents page.

---------

Co-authored-by: Andrew Burke <31974658+atburke@users.noreply.github.com>
Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Co-authored-by: Lisa Kim <lisa@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants