-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve dynamodb permission error msg #42855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
added
backport/branch/v16
no-changelog
Indicates that a PR does not require a changelog entry
labels
Jun 12, 2024
zmb3
approved these changes
Jun 12, 2024
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
rosstimothy
approved these changes
Jun 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 12, 2024
@fspmarshall See the table below for backport results.
|
ptgott
pushed a commit
that referenced
this pull request
Jun 12, 2024
* improve dynamodb permission error msg * Update lib/backend/dynamo/atomicwrite.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
ptgott
added a commit
that referenced
this pull request
Jun 12, 2024
* Update host user groups for existing users (#41919) This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role. * improve dynamodb permission error msg (#42855) * improve dynamodb permission error msg * Update lib/backend/dynamo/atomicwrite.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Fix GCP metadata errors crashing Teleport (#42696) * Web: Fix differing duration between unified resource and access request page (#42742) * Web: refactor and fix anti-pattern in access request * Update affected teleterm files * Address CR and fix updating duration should update pending * Fix test and stories * Reorganize Access Controls guides Move Access Controls giudes into References or Admin Guides, as appropriate. Also reorganizes the Admin Guides section to reduce the size of the table of contents page. --------- Co-authored-by: Andrew Burke <31974658+atburke@users.noreply.github.com> Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Lisa Kim <lisa@goteleport.com>
ptgott
added a commit
that referenced
this pull request
Jun 12, 2024
* Update host user groups for existing users (#41919) This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role. * improve dynamodb permission error msg (#42855) * improve dynamodb permission error msg * Update lib/backend/dynamo/atomicwrite.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Fix GCP metadata errors crashing Teleport (#42696) * Web: Fix differing duration between unified resource and access request page (#42742) * Web: refactor and fix anti-pattern in access request * Update affected teleterm files * Address CR and fix updating duration should update pending * Fix test and stories * Reorganize Access Controls guides Move Access Controls giudes into References or Admin Guides, as appropriate. Also reorganizes the Admin Guides section to reduce the size of the table of contents page. --------- Co-authored-by: Andrew Burke <31974658+atburke@users.noreply.github.com> Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Lisa Kim <lisa@goteleport.com>
ptgott
added a commit
that referenced
this pull request
Jun 17, 2024
* Update host user groups for existing users (#41919) This change fixes a bug in host user creation where Teleport would not update the groups of a returning user if groups were changed in the user's role. * improve dynamodb permission error msg (#42855) * improve dynamodb permission error msg * Update lib/backend/dynamo/atomicwrite.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Fix GCP metadata errors crashing Teleport (#42696) * Web: Fix differing duration between unified resource and access request page (#42742) * Web: refactor and fix anti-pattern in access request * Update affected teleterm files * Address CR and fix updating duration should update pending * Fix test and stories * Reorganize Access Controls guides Move Access Controls giudes into References or Admin Guides, as appropriate. Also reorganizes the Admin Guides section to reduce the size of the table of contents page. --------- Co-authored-by: Andrew Burke <31974658+atburke@users.noreply.github.com> Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Lisa Kim <lisa@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v16+ has an additional dynamodb permission requirement. This PR attempts to make the error a bit friendlier, so that anyone who misses the changelog entry can get things fixed quickly.