plugins: expand PluginStatusV1 to include runtime status details
#42962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
added
no-changelog
justinas
approved these changes
Jun 17, 2024
|
Generally looks good. What will the semantics of status updates be? E.g. if a code path emits the old barebones status (just the error code), will it override existing detailed integration-specific fields? |
We have no way of controlling this. Since this runs in auth, auth itself is responsible for updating the status field. If it's not aware of this change, it will replace whatever is in the db |
jakule
approved these changes
Jun 21, 2024
nklaassen
approved these changes
Jun 21, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rudream
This PR extends Teleport PluginStatusV1 to include details about the status of the runtime status of a plugin. These details include: - error message - last sync time - number of objects imported in gitlab Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/add-gitlab-plugin-status
branch
from
6275617
to
5dfacd8
Compare
tigrato
added a commit
that referenced
this pull request
Jun 25, 2024
…42962) * plugins: expand `PluginStatusV1` to include runtime status details This PR extends Teleport PluginStatusV1 to include details about the status of the runtime status of a plugin. These details include: - error message - last sync time - number of objects imported in gitlab Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * fix field refs --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this pull request
Jun 25, 2024
…42962) * plugins: expand `PluginStatusV1` to include runtime status details This PR extends Teleport PluginStatusV1 to include details about the status of the runtime status of a plugin. These details include: - error message - last sync time - number of objects imported in gitlab Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * fix field refs --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added a commit
that referenced
this pull request
Jun 25, 2024
…42962) * plugins: expand `PluginStatusV1` to include runtime status details This PR extends Teleport PluginStatusV1 to include details about the status of the runtime status of a plugin. These details include: - error message - last sync time - number of objects imported in gitlab Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * fix field refs --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…42962) (#43471) * plugins: expand `PluginStatusV1` to include runtime status details This PR extends Teleport PluginStatusV1 to include details about the status of the runtime status of a plugin. These details include: - error message - last sync time - number of objects imported in gitlab * fix field refs --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…42962) (#43470) * plugins: expand `PluginStatusV1` to include runtime status details This PR extends Teleport PluginStatusV1 to include details about the status of the runtime status of a plugin. These details include: - error message - last sync time - number of objects imported in gitlab * fix field refs --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…42962) (#43469) * plugins: expand `PluginStatusV1` to include runtime status details This PR extends Teleport PluginStatusV1 to include details about the status of the runtime status of a plugin. These details include: - error message - last sync time - number of objects imported in gitlab * fix field refs --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends Teleport PluginStatusV1 to include details about the status of the runtime status of a plugin. These details include: