Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that an FQDN belongs to a known app before redirecting to it #43525

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

capnspacehook
Copy link
Contributor

@capnspacehook capnspacehook commented Jun 26, 2024

This comment was marked as resolved.

@capnspacehook capnspacehook force-pushed the capnspacehook/open-url-redirect-fix branch 3 times, most recently from 9c39278 to e0217a3 Compare June 27, 2024 17:11
@capnspacehook capnspacehook force-pushed the capnspacehook/open-url-redirect-fix branch from e0217a3 to 6a9571e Compare July 2, 2024 14:53
@capnspacehook capnspacehook force-pushed the capnspacehook/open-url-redirect-fix branch from ff1259d to e679a09 Compare July 8, 2024 20:25
@capnspacehook capnspacehook added this pull request to the merge queue Jul 13, 2024
Merged via the queue into master with commit e22c004 Jul 13, 2024
38 checks passed
@capnspacehook capnspacehook deleted the capnspacehook/open-url-redirect-fix branch July 13, 2024 01:36
@public-teleport-github-review-bot

@capnspacehook See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR
branch/v16 Create PR

@marcoandredinis
Copy link
Contributor

This might have break AWS App Access when using an Integration
The app_server that exists looks like this

kind: app_server
metadata:
  name: teleportdev
spec:
  app:
#...
    spec:
      integration: teleportdev
      public_addr: teleportdev.dinis.cloud.gravitational.io:443
      uri: https://console.aws.amazon.com
#...
version: v3

When I click to open the AWS Console, I can see that at first the url looks like this

https://dinis.cloud.gravitational.io/web/launch/teleportdev.dinis.cloud.gravitational.io:443/dinis.cloud.gravitational.io/teleportdev.dinis.cloud.gravitational.io:443/arn:aws:iam::123456789012:role%2FMarcoTestReadOnlyAccess

But then, it loses the port in the URL right after /launch/ when generating the 2nd URL (the one that has the state)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants