Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Remove index.ejs from web package #43728

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Jul 1, 2024

Backport #43717 to branch/v14

This PR removes the index.ejs template file which is a relic from
webpack. When skipping webasset builds, we can just copy the index.html
file instead of the ejs file as vite handles the rest
@avatus avatus added the no-changelog Indicates that a PR does not require a changelog entry label Jul 1, 2024
@github-actions github-actions bot requested review from rosstimothy and zmb3 July 1, 2024 23:00
@avatus avatus enabled auto-merge July 1, 2024 23:03
@avatus avatus added this pull request to the merge queue Jul 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2024
@avatus avatus added this pull request to the merge queue Jul 2, 2024
Merged via the queue into branch/v14 with commit a4042d2 Jul 2, 2024
37 checks passed
@avatus avatus deleted the bot/backport-43717-branch/v14 branch July 2, 2024 00:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants