[v16] Allow a custom SSH dial timeout to be set cluster wide #45650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
approved these changes
Aug 21, 2024
|
Friendly ping @tigrato |
tigrato
approved these changes
Aug 22, 2024
public-teleport-github-review-bot
bot
removed the request for review
from zmb3
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
rosstimothy
force-pushed
the
tross/backport-45507/v16
branch
from
604dc64
to
a8da20f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
A new SSHDialTimeout field is added to the ClusterNetworkingConfiguration to allow cluster admins to override the default dial timeout of 30s. The dial timeout is made available in /webapi/ping, stored in the tsh profile, and cached on disk like other similar cluster settings so that tsh ssh can consume the relevant information without requiring an additional round trip to the cluster. At the moment, there is no support for an unlimited dial timeout, as that would cause complexity with backwards compatibility.
rosstimothy
force-pushed
the
tross/backport-45507/v16
branch
from
a8da20f
to
e4d6868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #45507 to branch/v16
Changelog: Permit setting a cluster wide SSH connection dial timeout