Implement RFD 19: Event Iteration API #6731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xacrimon
added
cloud
|
@fspmarshall @quinqu @andrejtokarcik You three are the assigned reviewers, can you review? |
xacrimon
force-pushed
the
joel/event-api-pagination
branch
4 times, most recently
from
d080fe6
to
d084f6b
Compare
quinqu
reviewed
May 10, 2021
xacrimon
commented
May 10, 2021
xacrimon
force-pushed
the
joel/event-api-pagination
branch
3 times, most recently
from
95f3b8d
to
88f07de
Compare
fspmarshall
reviewed
May 10, 2021
xacrimon
force-pushed
the
joel/event-api-pagination
branch
from
558220e
to
14d74f1
Compare
| @@ -81,6 +84,10 @@ func (s *DynamoeventsSuite) SetUpTest(c *check.C) { | |||
| c.Assert(err, check.IsNil) | |||
| } | |||
|
|
|||
| func (s *DynamoeventsSuite) TestPagination(c *check.C) { | |||
| s.EventPagination(c) | |||
There was a problem hiding this comment.
Would it be too cumbersome to introduce this as a test based on the testing module in accordance with our new testing guidelines?
There was a problem hiding this comment.
I think it is, in order to not introduce a lot of code duplication and weird logic it only really makes sense if we rewrite all of these suite tests which I'd rather not do in this already gigantic (in terms of delta) PR.
andrejtokarcik
approved these changes
May 17, 2021
This was referenced May 18, 2021
xacrimon
added a commit
that referenced
this pull request
May 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements the additional API endpoints described in RFD 19 and modifies event drivers to add this functionality to the various backends.
Details
This adds two additional endpoints onto the gRPC auth service in accordance with RFD 19 and rewrites the backend event drivers to support pagination.
Related Issues
Fixes #5435
Enterprise PR
This PR needs changes to be made to teleport.e. The pair PR is https://github.com/gravitational/teleport.e/pull/257
Other
This PR is based on the branch of #6583 and that PR must be merged before this is reviewed in order for the diff to make sense.
Needs a backport to
branch/v6after merge.cc @kimlisa