Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Re-add space after type in service definition #9503

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

webvictim
Copy link
Contributor

The whitespace after type: was being trimmed, which was causing a lint error. Not sure how this got through the linter in the first place.

The whitespace after `type:` was being trimmed, which was causing a lint error. Not sure how this got through the linter in the first place.
@webvictim webvictim added the helm label Dec 20, 2021
@webvictim webvictim self-assigned this Dec 20, 2021
@webvictim webvictim enabled auto-merge (squash) December 20, 2021 18:30
@webvictim
Copy link
Contributor Author

/gcbrun

@webvictim webvictim merged commit 08c4d66 into branch/v8 Dec 20, 2021
@webvictim webvictim deleted the gus/v8/helm-service-fix branch December 20, 2021 21:50
@greedy52
Copy link
Contributor

Thanks a lot @webvictim 👍

webvictim added a commit that referenced this pull request Jan 4, 2022
The whitespace after `type:` was being trimmed, which was causing a lint error. Not sure how this got through the linter in the first place.
webvictim added a commit that referenced this pull request Jan 15, 2022
* [helm] Re-add space after type in service definition (#9503)

The whitespace after `type:` was being trimmed, which was causing a lint error. Not sure how this got through the linter in the first place.

* helm: Adds log configuration to teleport-kube-agent chart

* Remove erroneous value

* Update reference.mdx

Remove shell prompt character
webvictim added a commit that referenced this pull request Jan 17, 2022
* [helm] Re-add space after type in service definition (#9503)

The whitespace after `type:` was being trimmed, which was causing a lint error. Not sure how this got through the linter in the first place.

* helm: Adds log configuration to teleport-kube-agent chart

* Remove erroneous value

* Update reference.mdx

Remove shell prompt character
webvictim added a commit that referenced this pull request Jan 26, 2022
…9814)

* [helm] Re-add space after type in service definition (#9503)

The whitespace after `type:` was being trimmed, which was causing a lint error. Not sure how this got through the linter in the first place.

* helm: Adds log configuration to teleport-kube-agent chart

* Remove erroneous value

* Update reference.mdx

Remove shell prompt character
@webvictim webvictim mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants