This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
[Discover] Refactor SetupAccess Screens #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
requested review from
ryanclark,
rudream,
hatched and
JanKaczmarkiewicz
packages/teleport/src/Discover/Database/SetupAccess/SetupAccess.tsx
Outdated
Show resolved
Hide resolved
packages/teleport/src/Discover/Kubernetes/SetupAccess/SetupAccess.tsx
Outdated
Show resolved
Hide resolved
packages/teleport/src/Discover/Shared/SetupAccess/useUserTraits.ts
Outdated
Show resolved
Hide resolved
packages/teleport/src/Discover/Shared/SetupAccess/useUserTraits.ts
Outdated
Show resolved
Hide resolved
packages/teleport/src/Discover/Shared/SetupAccess/useUserTraits.ts
Outdated
Show resolved
Hide resolved
packages/teleport/src/Discover/Shared/SetupAccess/useUserTraits.ts
Outdated
Show resolved
Hide resolved
packages/teleport/src/Discover/Shared/SetupAccess/useUserTraits.ts
Outdated
Show resolved
Hide resolved
packages/teleport/src/Discover/Shared/SetupAccess/SetupAccessWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/teleport/src/Discover/Server/SetupAccess/SetupAccess.tsx
Outdated
Show resolved
Hide resolved
packages/teleport/src/Discover/Server/SetupAccess/SetupAccess.tsx
Outdated
Show resolved
Hide resolved
kimlisa
force-pushed
the
lisa/refactor-setup-access
branch
from
c203961
to
adb8723
Compare
hatched
approved these changes
Nov 1, 2022
packages/build/.eslintrc.js
Outdated
| 'react/jsx-no-useless-fragment': 2, | ||
|
|
||
| 'react-hooks/rules-of-hooks': 'warn', | ||
| 'react-hooks/exhaustive-deps': 'warn', |
There was a problem hiding this comment.
Maybe keep this syntax consistent, so swap these for 1's
|
|
||
| useEffect(() => { | ||
| fetchUserTraits(); | ||
| }, []); |
There was a problem hiding this comment.
If leaving the dependencies blank is intentional can you add a comment and a //eslint ignore label here so a future dev knows this was an intentional decision.
There was a problem hiding this comment.
| authType: 'local', | ||
| userName: 'llama', | ||
| accessCapabilities: { | ||
| suggestedReviewers: ['george_washington@gmail.com', 'alpha'], |
kimlisa
force-pushed
the
lisa/refactor-setup-access
branch
2 times, most recently
from
d33e79a
to
c0914fe
Compare
|
@JanKaczmarkiewicz i moved adding new eslint rules and fixing lint errors in this PR: #1327 |
- create a reusable hook related to setup access and user traits - create a setup access wrapper that dedups repeated logic - rename and added more yaml readers
kimlisa
force-pushed
the
lisa/refactor-setup-access
branch
from
c0914fe
to
0510791
Compare
|
@JanKaczmarkiewicz friendly ping |
JanKaczmarkiewicz
approved these changes
Nov 7, 2022
kimlisa
added a commit
that referenced
this pull request
Nov 15, 2022
* Create user trait hook and setup access wrapper - create a reusable hook related to setup access and user traits - create a setup access wrapper that dedups repeated logic - rename and added more yaml readers * Create SetupAccess screen for database * Refactor SetupAccess for kube * Refactor SetupAccess for server * Add database json vals and prevent infinite rendering from dependency array
kimlisa
added a commit
that referenced
this pull request
Nov 16, 2022
* Create user trait hook and setup access wrapper - create a reusable hook related to setup access and user traits - create a setup access wrapper that dedups repeated logic - rename and added more yaml readers * Create SetupAccess screen for database * Refactor SetupAccess for kube * Refactor SetupAccess for server * Add database json vals and prevent infinite rendering from dependency array
kimlisa
added a commit
that referenced
this pull request
Nov 16, 2022
* Create user trait hook and setup access wrapper - create a reusable hook related to setup access and user traits - create a setup access wrapper that dedups repeated logic - rename and added more yaml readers * Create SetupAccess screen for database * Refactor SetupAccess for kube * Refactor SetupAccess for server * Add database json vals and prevent infinite rendering from dependency array
kimlisa
added a commit
that referenced
this pull request
Nov 16, 2022
* Create user trait hook and setup access wrapper - create a reusable hook related to setup access and user traits - create a setup access wrapper that dedups repeated logic - rename and added more yaml readers * Create SetupAccess screen for database * Refactor SetupAccess for kube * Refactor SetupAccess for server * Add database json vals and prevent infinite rendering from dependency array
kimlisa
added a commit
that referenced
this pull request
Nov 16, 2022
* Create user trait hook and setup access wrapper - create a reusable hook related to setup access and user traits - create a setup access wrapper that dedups repeated logic - rename and added more yaml readers * Create SetupAccess screen for database * Refactor SetupAccess for kube * Refactor SetupAccess for server * Add database json vals and prevent infinite rendering from dependency array
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of gravitational/teleport#16858
Note: Easier to review by commit, tried to contain specific changes. I think half of the changes are file deletes, and simple yaml file addition and changes.
Description
TODO
Figma - DB setup access screen
https://www.figma.com/file/8DQZl1mYUPLgvKgmA6zPOM/In-Progress-Work?node-id=1299%3A69270
Screenshot
Looks pretty sim to figma, all other states are available in storybook under
Teleport/Discover/*