-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: configure kubernetes synchronizer to watch All or specifiec name… #2460
Conversation
...s-sync/src/main/java/io/gravitee/gateway/services/sync/kubernetes/KubernetesSyncService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if using labels would not be more flexible 🤔 And more in the ways of doing k8s 🤷♂️
but both would be even better 😁 WDYT @sebdevaux
What do you think about adding some tests on it ?
...s-sync/src/main/java/io/gravitee/gateway/services/sync/kubernetes/KubernetesSyncService.java
Outdated
Show resolved
Hide resolved
There will surely be things to change here too. |
@brasseld , @ThibaudAV can you please approve this PR if nothing else needs to be modified. |
...ndalone/gravitee-apim-gateway-standalone-distribution/src/main/resources/config/gravitee.yml
Outdated
Show resolved
Hide resolved
@kamiiiel Do we agree that if no namespace is configured, then we are watching all namespaces ? |
If we don't provide any namespace, we only listen to the current namespace that the gateway is running inside it. |
592ec44
to
37a5bb1
Compare
37a5bb1
to
118b6dc
Compare
Description
At the moment Kubernetes synchroniser is watching all namespaces and there is no way to configure it. This PR will make the synchronizer to only watch to the current namespace that the Gateway is running inside it by default but the user can change this behaviour by setting the 'namespace' attribute.
🚀 CI was able to deploy the build of this PR, so you can now try it directly here
Notes: The deployed app is linked to the management API of APIM master. (Same login and password as APIM master)
📚 View the storybook of this branch here