feat(user): return 404 when user when user doesn't have avatar

Closes gravitee-io/issues#2898

gravitee-rest-api-portal/gravitee-rest-api-portal-rest/src/main/java/io/gravitee/rest/api/portal/rest/resource/AbstractResource.java

@@ -341,6 +341,9 @@ protected Response createListResponse(List dataList, PaginationParam paginationP
     }
 
     protected Response createPictureReponse(Request request, InlinePictureEntity image) {
+        if (image == null || image.getContent() == null) {
+            return Response.status(Status.NOT_FOUND).build();
+        }
         CacheControl cc = new CacheControl();
         cc.setNoTransform(true);
         cc.setMustRevalidate(false);
@@ -418,4 +421,4 @@ public int hashCode() {
         }
 
     }
-}
+}

gravitee-rest-api-service/src/main/java/io/gravitee/rest/api/service/impl/UserServiceImpl.java

@@ -122,9 +122,7 @@ public class UserServiceImpl extends AbstractService implements UserService {
     private GenericNotificationConfigService genericNotificationConfigService;
     @Autowired
     private GroupService groupService;
-
-    @Value("${user.avatar:${gravitee.home}/assets/default_user_avatar.png}")
-    private String defaultAvatar;
+
     @Value("${user.login.defaultApplication:true}")
     private boolean defaultApplicationForFirstConnection;
 
@@ -390,14 +388,9 @@ public PictureEntity getPicture(String id) {
             }
         }
 
-        // Return default inline user avatar
+        // Return empty image
         InlinePictureEntity imageEntity = new InlinePictureEntity();
         imageEntity.setType("image/png");
-        try {
-            imageEntity.setContent(IOUtils.toByteArray(new FileInputStream(defaultAvatar)));
-        } catch (IOException ioe) {
-            LOGGER.error("Default icon for API does not exist", ioe);
-        }
         return imageEntity;
     }