Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[portal] user/avatar should return 404 when user doesn't have avatar #2898

Closed
3 tasks done
gcusnieux opened this issue Nov 18, 2019 · 0 comments · Fixed by gravitee-io/gravitee-management-webui#1079 or gravitee-io/gravitee-management-rest-api#802
Closed
3 tasks done

[portal] user/avatar should return 404 when user doesn't have avatar #2898

gcusnieux opened this issue Nov 18, 2019 · 0 comments · Fixed by gravitee-io/gravitee-management-webui#1079 or gravitee-io/gravitee-management-rest-api#802
Assignees
@gcusnieux
Labels
project: APIM type: technical
Projects
API Management
Milestone
APIM - 3.0.0 - alpha

Comments

@gcusnieux
Copy link
Member

gcusnieux commented Nov 18, 2019 •
edited

  • In rest-api, return 404 when user does not have avatar
  • In portal-webui, use jdenticon when image not load
  • In management-webui, use default-avatar when image not load
@gcusnieux gcusnieux changed the title [portal] user/avatar should return 404 when user not have avatar [portal] user/avatar should return 404 when user doesn't have avatar Nov 18, 2019
gcusnieux added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Nov 18, 2019
@gcusnieux
feat(user): return 404 when user when user doesn't have avatar
bf3139d 
Closes gravitee-io/issues#2898
gcusnieux added a commit to gravitee-io/gravitee-management-webui that referenced this issue Nov 18, 2019
@gcusnieux
feat: use default avatar when image not load
edd39c7 
Closes gravitee-io/issues#2898
gcusnieux added a commit to gravitee-io/gravitee-management-webui that referenced this issue Nov 18, 2019
@gcusnieux
feat: use default avatar when image not load
9824de0 
Closes gravitee-io/issues#2898
@gcusnieux gcusnieux mentioned this issue Nov 18, 2019
Merged
@gcusnieux gcusnieux self-assigned this Nov 18, 2019
gcusnieux added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Nov 18, 2019
@gcusnieux
feat(user): return 404 when user when user doesn't have avatar
1aaae23 
Closes gravitee-io/issues#2898
@gcusnieux gcusnieux mentioned this issue Nov 18, 2019
Merged
gcusnieux added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Nov 18, 2019
@gcusnieux
feat(user): return 404 when user when user doesn't have avatar
bc6986c 
Closes gravitee-io/issues#2898
gcusnieux added a commit to gravitee-io/gravitee-management-webui that referenced this issue Nov 18, 2019
@gcusnieux
feat: use default avatar when image not load
e6e0bb0 
Closes gravitee-io/issues#2898
gcusnieux added a commit to gravitee-io/gravitee-management-webui that referenced this issue Nov 27, 2019
@gcusnieux
feat: use default avatar when image not load
3b36f3e 
Closes gravitee-io/issues#2898
gcusnieux added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Nov 27, 2019
@gcusnieux
feat(user): return 404 when user when user doesn't have avatar
8861a99 
Closes gravitee-io/issues#2898
aelamrani pushed a commit to gravitee-io/gravitee-management-webui that referenced this issue Nov 27, 2019
@gcusnieux @aelamrani
feat: use default avatar when image not load
4c14ac6 
Closes gravitee-io/issues#2898
aelamrani pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Nov 27, 2019
@gcusnieux @aelamrani
feat(user): return 404 when user when user doesn't have avatar
7b08946 
Closes gravitee-io/issues#2898
@phiz71 phiz71 mentioned this issue Mar 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcusnieux gcusnieux

Labels
project: APIM type: technical
Projects
API Management
Awaiting triage
Milestone
APIM - 3.0.0 - alpha
2 participants
@gcusnieux @aelamrani