This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
fix(view): Update API views when removing a view #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelamrani
reviewed
Nov 21, 2016
| @@ -622,13 +622,29 @@ public ImageEntity getPicture(String apiId) { | |||
| @Override | |||
| public void deleteViewFromAPIs(final String viewId) { | |||
| findAll().forEach(api -> { | |||
| if (api.getViews() | |||
| if (api.getViews() != null && api.getViews() | |||
| .removeIf(view -> view.equals(viewId))) { | |||
There was a problem hiding this comment.
Not sur the removeIf is necessary here..
There was a problem hiding this comment.
? I mean not anymore necessary with your refactor...
There was a problem hiding this comment.
I don't understand why but I let you apply necessary changes.
There was a problem hiding this comment.
You are doing a remove of view twice : once by the removeIf, and on the remove() method...
| } | ||
| }); | ||
| } | ||
|
|
||
| private void removeView(String apiId, String viewId) throws TechnicalManagementException { | ||
| try { | ||
| Optional<Api> optApi = apiRepository.findById(apiId); |
There was a problem hiding this comment.
Not better to give the api object in parameter?
There was a problem hiding this comment.
so let's do required changes...
brasseld
force-pushed
the
issue/#317-delete-view
branch
from
2318b57
to
a4930d0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gravitee-io/issues#317