Merge 19.xfixes #32
Merged
Merge 19.xfixes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaeyaert
force-pushed
the
merge-19.xfixes
branch
from
e3123b2
to
4af4f5b
Compare
|
LGTM , one more thing, if possible, to include :
|
Jean-Baptiste-Lasselle
suggested changes
Jun 2, 2021
There was a problem hiding this comment.
one more thing, if possible, to include :
- upgrade jacoco maven plugin version to
0.8.6 - tested with: https://github.com/gravitee-io/gravitee-common/blob/d1df642d266a4537a1160593f582bad26a2f607e/pom.xml#L36
- that's for QA
| <jersey.version>2.30.1</jersey.version> | ||
| <logback.version>1.2.3</logback.version> | ||
| <mockito.version>2.24.5</mockito.version> | ||
| <mockito.version>3.6.0</mockito.version> | ||
| <jackson.version>2.10.3</jackson.version> | ||
| <rxjava.version>2.2.19</rxjava.version> | ||
| <reactive-streams.version>1.0.3</reactive-streams.version> | ||
| <jacoco-maven-plugin.version>0.7.7.201606060606</jacoco-maven-plugin.version> |
There was a problem hiding this comment.
one more thing, if possible, to include :
- upgrade jacoco maven plugin version to
0.8.6 - tested with: https://github.com/gravitee-io/gravitee-common/blob/d1df642d266a4537a1160593f582bad26a2f607e/pom.xml#L36
- that's for QA
There was a problem hiding this comment.
You pointed the mockito version but talk about jacoco version. Is it a mistake ?
Anyway, I would prefer to handle the jacoco upgrade in a dedicated PR as it is not related to this one (which is about merging the branch 19.xfixes into master).
There was a problem hiding this comment.
Sry about the mmispointed link ... tyhe part I meant to point at is <jacoco-maven-plugin.version>0.8.6</jacoco-maven-plugin.version>
There was a problem hiding this comment.
ok lert's do jacoco upgrade separately
…ee repos which had a gravitee-parent 19
…y changing the logback configuration Closes gravitee-io/issues#5139
jhaeyaert
force-pushed
the
merge-19.xfixes
branch
from
4af4f5b
to
1ba129b
Compare
Jean-Baptiste-Lasselle
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.