-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 19.xfixes #32
Merged
Merged
Merge 19.xfixes #32
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5e9aa53
version 19 compatible with both Circle CI and Jenkins, for all gravit…
Jean-Baptiste-Lasselle b560333
chore: Add the libraries to allow to write application logs in JSON b…
aelamrani d06336f
chore: update mockito to 3.6.0
ytvnr 4ada9d3
chore: Update vert.x library to 3.9
aelamrani ee5878f
fix: APIM dependencies upgrade
aelamrani 1ba129b
fix: Error when updating user's avatar
aelamrani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing, if possible, to include :
0.8.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You pointed the mockito version but talk about jacoco version. Is it a mistake ?
Anyway, I would prefer to handle the jacoco upgrade in a dedicated PR as it is not related to this one (which is about merging the branch 19.xfixes into master).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry about the mmispointed link ... tyhe part I meant to point at is
<jacoco-maven-plugin.version>0.8.6</jacoco-maven-plugin.version>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok lert's do jacoco upgrade separately