Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): round license expiration countdown number #379

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix(angular): round license expiration countdown number #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...gio-license-expiration-notification/gio-license-expiration-notification.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,17 @@ describe('GioLicenseExpirationNotificationComponent', () => {
expect(await harness.getTitleText()).toEqual('Your license will expire in 10 days');
});

it('should display countdown message of whole number', async () => {
const expirationDate = new Date();
expirationDate.setDate(expirationDate.getDate() + 29);

component.expirationDate = expirationDate;
fixture.detectChanges();

const harness = await loader.getHarness(GioLicenseExpirationNotificationHarness);
expect(await harness.getTitleText()).toEqual('Your license will expire in 29 days');
});

it('should display call to action', async () => {
component.showCallToAction = true;
fixture.detectChanges();
Expand Down
2 changes: 1 addition & 1 deletion .../lib/gio-license-expiration-notification/gio-license-expiration-notification.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class GioLicenseExpirationNotificationComponent implements OnInit, OnChan

const date = new Date();
const timeRemaining = this.transformDateWithoutHours(this.expirationDate) - this.transformDateWithoutHours(date);
this.daysRemaining = timeRemaining / (1000 * 3600 * 24);
this.daysRemaining = Math.round(timeRemaining / (1000 * 3600 * 24));

if (this.expirationDate.getTime() - date.getTime() < 0) {
this.title = 'Your license has expired';
Expand Down