Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management] Do not detect redeploy on each plan update #1827

Closed
NicolasGeraud opened this issue Jan 16, 2019 · 0 comments
Closed

[management] Do not detect redeploy on each plan update #1827

NicolasGeraud opened this issue Jan 16, 2019 · 0 comments
Assignees
@NicolasGeraud
Labels
project: APIM type: bug
Milestone
APIM - 1.20.12

Comments

@NicolasGeraud
Copy link
Member

Even if you update "portal" data of a plan (name, description, characteristics, ...) Gravitee detect an update a say that a deploy is needed.

see https://github.com/gravitee-io/gravitee-management-rest-api/blob/b25ebcb93b9e4e1dfa11b2ab3d6f492d72cbd642/gravitee-management-api-service/src/main/java/io/gravitee/management/service/impl/ApiServiceImpl.java#L608

Expected Behavior

only ask to redeploy if the update impact the gateway behavior.

Steps to Reproduce (for bugs)

  1. open a plan
  2. next, next, next, save
  3. gravitee says that you need to redeploy

Your Environment

  • Version used: 1.20.x
@NicolasGeraud NicolasGeraud added this to the 1.20.11 milestone Jan 16, 2019
NicolasGeraud added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
74077e4 
fix gravitee-io/issues#1827
NicolasGeraud added a commit to gravitee-io/gravitee-repository that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
8673c93 
fix gravitee-io/issues#1827
@NicolasGeraud NicolasGeraud self-assigned this Jan 17, 2019
NicolasGeraud added a commit to gravitee-io/gravitee-repository-test that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
6a7470f 
fix gravitee-io/issues#1827
NicolasGeraud added a commit to gravitee-io/gravitee-repository-redis that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
ef3c329 
fix gravitee-io/issues#1827
NicolasGeraud added a commit to gravitee-io/gravitee-repository-mongodb that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
3543c93 
fix gravitee-io/issues#1827
NicolasGeraud added a commit to gravitee-io/gravitee-repository that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
34f4181 
fix gravitee-io/issues#1827
NicolasGeraud added a commit to gravitee-io/gravitee-repository-test that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
b895238 
fix gravitee-io/issues#1827
NicolasGeraud added a commit to gravitee-io/gravitee-repository-mongodb that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
5f71fca 
fix gravitee-io/issues#1827
NicolasGeraud added a commit to gravitee-io/gravitee-repository-jdbc that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
e644e20 
fix gravitee-io/issues#1827
@NicolasGeraud NicolasGeraud mentioned this issue Jan 17, 2019
Merged
This was referenced Jan 17, 2019
Merged
Merged
Merged
Merged
NicolasGeraud added a commit to gravitee-io/gravitee-repository-jdbc that referenced this issue Jan 17, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
2cd0ce6 
fix gravitee-io/issues#1827
@NicolasGeraud NicolasGeraud modified the milestones: 1.20.11, 1.20.12 Jan 23, 2019
@NicolasGeraud NicolasGeraud mentioned this issue Feb 4, 2019
Merged
NicolasGeraud added a commit to gravitee-io/gravitee-repository-redis that referenced this issue Feb 5, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
cc7cbe5 
fix gravitee-io/issues#1827
tcompiegne pushed a commit to gravitee-io/gravitee-repository that referenced this issue Feb 14, 2019
@NicolasGeraud @tcompiegne
fix(plan) do not redeploy api on every plan modification
bbf2b38 
fix gravitee-io/issues#1827
tcompiegne pushed a commit to gravitee-io/gravitee-repository-test that referenced this issue Feb 14, 2019
@NicolasGeraud @tcompiegne
fix(plan) do not redeploy api on every plan modification
d368272 
fix gravitee-io/issues#1827
tcompiegne pushed a commit to gravitee-io/gravitee-repository-mongodb that referenced this issue Feb 14, 2019
@NicolasGeraud @tcompiegne
fix(plan) do not redeploy api on every plan modification
be40864 
fix gravitee-io/issues#1827
tcompiegne pushed a commit to gravitee-io/gravitee-repository-jdbc that referenced this issue Feb 14, 2019
@NicolasGeraud @tcompiegne
fix(plan) do not redeploy api on every plan modification
2ff8c13 
fix gravitee-io/issues#1827
tcompiegne pushed a commit to gravitee-io/gravitee-repository-redis that referenced this issue Feb 14, 2019
@NicolasGeraud @tcompiegne
fix(plan) do not redeploy api on every plan modification
be3732c 
fix gravitee-io/issues#1827
NicolasGeraud added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Feb 14, 2019
@NicolasGeraud
fix(plan) do not redeploy api on every plan modification
bb898ca 
fix gravitee-io/issues#1827
tcompiegne pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Feb 14, 2019
@NicolasGeraud @tcompiegne
fix(plan) do not redeploy api on every plan modification
07c7a4c 
fix gravitee-io/issues#1827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicolasGeraud NicolasGeraud

Labels
project: APIM type: bug
Projects
None yet
Milestone
APIM - 1.20.12
Development

No branches or pull requests
2 participants
@NicolasGeraud @tcompiegne