Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] add more precision when rounded the healthcheck percentage #2168

Closed
NicolasGeraud opened this issue Apr 25, 2019 · 0 comments

Comments

Projects
None yet
3 participants
@NicolasGeraud
Copy link
Member

commented Apr 25, 2019

If the heath status for the last hour is 99.92663653898603, we display a green bar with 100%.

The consequence is that errors are hidden

Your Environment

  • Version used: 1.20.x

@NicolasGeraud NicolasGeraud added this to the APIM - 1.20.16 milestone Apr 25, 2019

@NicolasGeraud NicolasGeraud self-assigned this Apr 25, 2019

phiz71 added a commit to gravitee-io/gravitee-management-webui that referenced this issue May 6, 2019

fix(): improve healthcheck percentage display
Creation of :
 - a new component to manage healthcheck metric
 - a new directive to floor the metric value to the nearest integer

Code refactoring

Fix gravitee-io/issues#2168.

phiz71 added a commit to gravitee-io/gravitee-management-webui that referenced this issue May 6, 2019

fix(): improve healthcheck percentage display
Creation of :
 - a new component to manage healthcheck metric
 - a new directive to floor the metric value to the nearest integer

Code refactoring

Fix gravitee-io/issues#2168.

brasseld added a commit to gravitee-io/gravitee-management-webui that referenced this issue May 7, 2019

fix(): improve healthcheck percentage display
Creation of :
 - a new component to manage healthcheck metric
 - a new directive to floor the metric value to the nearest integer

Code refactoring

Fix gravitee-io/issues#2168.

@brasseld brasseld closed this May 7, 2019

@NicolasGeraud NicolasGeraud assigned phiz71 and unassigned NicolasGeraud May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.