Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform] [node] Technical API _node/configuration end-point doesn't resolve env variables #3419

Closed
gasparir opened this issue Apr 3, 2020 · 3 comments

Comments

@gasparir
Copy link

gasparir commented Apr 3, 2020

GET /_node/configuration
returns the content of the default gravitee.yml of the distribution, without any c

Expected Behavior

As described here: https://docs.gravitee.io/apim/1.x/apim_installguide_management_api_technical_api.html
the end-point should also return the env vars

Current Behavior

No env vars resolution

Steps to Reproduce (for bugs)

  1. on mgmt-api: wget http://localhost:18083/_node/configuration

Context

Trying to understand if all my env vars are correctly loaded.

Your Environment

  • Version used: 1.30.7, mgmt-api
@NicolasGeraud NicolasGeraud added this to the APIM - 1.30.x milestone Apr 17, 2020
@NicolasGeraud
Copy link
Member

Indeed it's an error in the documentation, we only get the configuration file.

But you're right, we have to also get environment variables and system properties. The problem is that we have to manage the override ...

@brasseld brasseld modified the milestones: APIM - 1.30.x, APIM - 1.30.9 Apr 21, 2020
brasseld added a commit to gravitee-io/gravitee-node that referenced this issue Apr 21, 2020
brasseld added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Apr 21, 2020
@brasseld brasseld changed the title Technical API _node/configuration end-point doesn't resolve env variables [platform] [node] Technical API _node/configuration end-point doesn't resolve env variables Apr 21, 2020
@brasseld brasseld self-assigned this Apr 21, 2020
@brasseld brasseld removed their assignment Apr 21, 2020
@brasseld brasseld modified the milestones: APIM - 1.30.9, APIM - 1.30.x Apr 21, 2020
@NicolasGeraud
Copy link
Member

@gasparir Hi,

we suggest to provide different query parameters to select which configuration you request (gravitee.yml, system properties, environment variables).
By default, we will return the gravitee.yml config.

@gasparir
Copy link
Author

@NicolasGeraud Hi.

thank you for looking at this. Proposed solution with query parameters would be fine for me.

brasseld added a commit to gravitee-io/gravitee-node that referenced this issue May 4, 2020
brasseld added a commit to gravitee-io/gravitee-api-management that referenced this issue May 4, 2020
@brasseld brasseld modified the milestones: APIM - 1.30.x, APIM - 1.30.10 May 4, 2020
NicolasGeraud pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue May 4, 2020
NicolasGeraud pushed a commit to gravitee-io/gravitee-node that referenced this issue May 4, 2020
NicolasGeraud pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue May 4, 2020
NicolasGeraud pushed a commit to gravitee-io/gravitee-api-management that referenced this issue May 4, 2020
aelamrani added a commit to gravitee-io/gravitee-api-management that referenced this issue May 18, 2020
* chore(): Prepare next version

* fix: Sometimes requests are not logged when api response time is not correct
fix gravitee-io/issues#2644

* chore(): Prepare next version

* feat(services): Add a user-agent header for all services requests

fix gravitee-io/issues#2854

* fix(path-mapping): Execute path-mapping processor also on response error

Closes gravitee-io/issues#2928

* release(1.25.16)

* chore(): Prepare next version

* chore: Update node dependency

Closes gravitee-io/issues#2963

* fix(prometheus): register HC service only on Prometheus

fix gravitee-io/issues#2979

* fix(forward): Remove the port from the x-forwarded-for header

Closes gravitee-io/issues#2937

* fix(log): do not log eventstream

fix gravitee-io/issues#2976

* feat(http): Add support for PKCS12 and PEM for HTTP server

Closes gravitee-io/issues#2978

* release(1.25.17)

* chore(): Prepare next version

* release(1.30.1)

* chore(): Prepare next version

* fix(gravitee.bat): wrong comment syntax

fix gravitee-io/issues#3050

* fix: The max size configuration of reporters is not well handled

Closes gravitee-io/issues#3005

* feat: We should avoid to log binary content

Closes gravitee-io/issues#3007

* release(1.25.18)

* chore(): Prepare next version

* fix: do not log stream event requests

Closes gravitee-io/issues#2976

* fix(http): Do not enable logActivity for HTTP client

Closes gravitee-io/issues#3056

* fix(health-check): Check rate-limiting repository asynchronously

Closes gravitee-io/issues#3091

* release(1.25.19)

* chore(): Prepare next version

* release(1.30.2)

* chore(): Prepare next version

* fix(metrics): some use cases generates 'failed to parse api-response-time'

fix gravitee-io/issues#2989

* release(1.25.20)

* chore(): Prepare next version

* fix(subscriptions): add only accepted subscription to the cache

fix gravitee-io/issues#3112

* release(1.25.21)

* chore(): Prepare next version

* fix: Some calls are reported with a negative response time

Closes gravitee-io/issues#3191

* feat(alert): Add support for geoip and user agent alerting processors

Closes gravitee-io/issues#3187

* feat(http): Provide better of client authentication mode

Closes gravitee-io/issues#3160

* release(1.30.3)

* chore(): Prepare next version

* fix(processors): store status code and response time on unknwon api calls

fix gravitee-io/issues#3216

* fix(response-template): Manage multiple accept headers with quality factor

Closes gravitee-io/issues#3212

* fix: Log unknown path for unknown APIs

Closes gravitee-io/issues#3195

* fix: End user is not logged when a policy fail

Closes gravitee-io/issues#3189

* fix: End user is not logged when a policy fail

Closes gravitee-io/issues#3189

* release(1.25.22)

* chore(): Prepare next version

* release(1.30.4)

* chore(): Prepare next version

* release(1.30.5)

* chore(): Prepare next version

* fix: Store metrics only if api key plan matches

Closes gravitee-io/issues#3308

* feat(service-discovery): Support configuration for https scheme and path override

Clsoes gravitee-io/issues#3294

* release(1.25.23)

* chore(): Prepare next version

* chore: Upgrade Policy API dependency

Closes gravitee-io/issues#3298

* feat(alert): Upgrade node dependencies to add support for alert on node healthcheck metrics

Closes gravitee-io/issues#3118

* release(1.30.6)

* chore(): Prepare next version

* release(1.30.7)

* chore(): Prepare next version

* release(1.25.24)

* fix(proxy): Send content-type even if no content to send

Closes gravitee-io/issues#3426

* chore: Upgrade nimbus-jwt dependency

Closes gravitee-io/issues#3427

* release(1.30.8)

* chore(): Prepare next version

* fix(alert): move to api 1.3.0

fix gravitee-io/issues#3499

* chore: Upgrade Jackson to fix CVE

Closes gravitee-io/issues#3535

* fix(ut): add jackson dependency

* chore(): upgrade parent to fix gpg error

* release(1.30.9)

* chore(): Prepare next version

* chore(dependencies): upgrade dependencies

spring 5.1.3 -> 5.2.5
snakeyaml 1.2.1 -> 1.2.6
json-path 2.2.0 -> 2.4.0
guava 26.0-jre -> 29.0-jre
jackson 2.9.8 -> 2.10.3

Closes gravitee-io/issues#3652

* chore: Upgrade Netty dependency

Closes gravitee-io/issues#3679

* fix(sync): API definition loading must be case-insensitive

Closes gravitee-io/issues#3682

* fix(api): Do not duplicate api's properties to avoid memory pressure

Closes gravitee-io/issues#3683

* chore: Upgrade gravitee-node dependency

Closes gravitee-io/issues#3419

* fix(processor): XForwardForProcessor should handle IPv6 value

fixes gravitee-io/issues#3444

* feat(policyChain): add PLAN_UNRESOLVABLE policy chain error key

closes gravitee-io/issues#3513

* release(1.30.10)

Co-authored-by: Gravitee.io Bot <contact@gravitee.io>
Co-authored-by: Nicolas Géraud <nicolas.geraud@gmail.com>
Co-authored-by: David BRASSELY <brasseld@gmail.com>
Co-authored-by: Azize Elamrani <azize.elamrani@gmail.com>
Co-authored-by: Titouan COMPIEGNE <titouan.compiegne@gmail.com>
aelamrani added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue May 18, 2020
* chore(): Prepare next version

* fix(audits): add api events

fix gravitee-io/issues#2883

* chore(): Prepare next version

* fix: Platform dashboard rights not correctly handled for widget response status

fix gravitee-io/issues#2868

* fix: When deleting an API, its pages should be also deleted

fix gravitee-io/issues#2844

* fix(swagger): Add documentation for analytics API

Closes gravitee-io/issues#2914

* fix(group): A group can be associated to existing APIs and or Apps

Closes gravitee-io/issues#2253

* fix(view): Do not update view's picture when re-ordering

Closes gravitee-io/issues#2909

* feat(services): Add a user-agent header for all services requests

fix gravitee-io/issues#2854

* fix(api): add controls on api creation and update

fix gravitee-io/issues#2938

* release(1.25.16)

* chore(): Prepare next version

* chore: Update node dependency

Closes gravitee-io/issues#2963

* fix(prometheus): register HC service only on Prometheus

fix gravitee-io/issues#2979

* fix(oauth): log user mapping error in warning

fix gravitee-io/issues#2973

* fix(quality-rules): do not require read access to get all quality rules

fix gravitee-io/issues#2984

* fix(analytics): Do not handle API and application with value '1' as deleted.

Closes gravitee-io/issues#2987

* feat(http): Add support for PKCS12 for HTTP server

Closes gravitee-io/issues#2978

* fix(analytics): replace '1' to '?' in analytics response

fix gravitee-io/issues#2988

* release(1.25.17)

* chore(): Prepare next version

* fix: Do not log message when a field is not mapped on an identity provider

Closes gravitee-io/issues#3016

* fix(email): do not throw error if email is disabled

fix gravitee-io/issues#3035

* doc: Add doc on how to add email on a user inmemory

Closes gravitee-io/issues#2590

* fix(email): do not send email if no recipient

fix gravitee-io/issues#3038

* release(1.30.1)

* chore(): Prepare next version

* fix(gravitee.bat): wrong comment syntax

fix gravitee-io/issues#3050

* feat(metadata): add EL support for the "email-support" API metadata

closes gravitee-io/issues#3049

* fix(api): delete memberships and notifications on delete

fix gravitee-io/issues#2711

* fix(ut): ApiService_DeleteTest ApplicationService_ArchiveTest

* release(1.25.18)

* chore(): Prepare next version

* fix(management): the enums not case-insensitive when an api is imported

Closes gravitee-io/issues#2995

* fix(logs): escape reserved words during research

fix gravitee-io/issues#3070

* release(1.25.19)

* chore(): Prepare next version

* release(1.30.2)

* chore(): Prepare next version

* release(1.25.20)

* chore(): Prepare next version

* fix: The configuration of an email on a user (in memory) does not work

Closes gravitee-io/issues#3103

* fix: Error trying to import API with primary owner without email

Closes gravitee-io/issues#3104

* fix(configuration): define sensitive data that cannot be seen outside the service

fix gravitee-io/issues#3082

* feat(application): display complete request URI in the application log detail

closes gravitee-io/issues#3107

* feat(maintenance): add a maintenance mode for the ui and api

fix gravitee-io/issues#3124

* fix(subscription): update subscription ending date

fix gravitee-io/issues#3149

* fix(apikey): expire date cannot ended after subscription

fix gravitee-io/issues#3153

* fix(management) API documentation import preserves folders structure

Fixes gravitee-io/issues#3129

* release(1.25.21)

* chore(): Prepare next version

* fix(pages) allow non admin to administrate portal pages

fix gravitee-io/issues#3174

* fix(analytics): report issues#3113 in default widgets

* release(1.30.3)

* chore(): Prepare next version

* fix(config): Bad defautl value for HTTP proxy

Closes gravitee-io/issues#3221

* fix(group): Reverse newly created entity and mapped entity

Closes gravitee-io/issues#3171

* feat(instance): Add instances filtering capabilities to avoid loading large set of data

Closes gravitee-io/issues#3222

* fix: Missing informations on email template for expired api-key

* fix(oauth): Add a state while doing oauth authentication

Closes gravitee-io/issues#3231

* fix(permission): Group permissions are merged with user permissions

Closes gravitee-io/issues#3238

* fix: Cors request considered as "Deleted Application"

Closes gravitee-io/issues#3228

* fix: Log unknown path for unknown APIs

Closes gravitee-io/issues#3195

* fix(container): Move JUL logs to SLF4j

Closes gravitee-io/issues#3229

* feat(idp): add firstname and lastname support for inmemory users

closes gravitee-io/issues#3234

* feat(user): Add a flag to indicate that the user is PO

Closes gravitee-io/issues#2425

* release(1.25.22)

* chore(): Prepare next version

* feat(swagger): Set server URLs depending on the entrypoints of the API

Closes gravitee-io/issues#3246

* release(1.30.4)

* chore(): Prepare next version

* Fix typo on configuration of proxy type

* fix: fail to parse Swagger page with dynamic freemarker values

Closes gravitee-io/issues#3259

* feat(logs): Provide a way to consult API logs from platform dashboard

Closes gravitee-io/issues#3233

* release(1.30.5)

* chore(): Prepare next version

* fix: Some users are wrongly flagged as primary owners

Closes gravitee-io/issues#3273

* fix(application): do not log in error a missing PO on a archived app

fix gravitee-io/issues#3273

* fix: Manual unlocking of detailed logging limitation

Closes gravitee-io/issues#3282

* fix: Use the correct log lever for errors on token exchange

Closes gravitee-io/issues#3267

* feat(swagger): Servers in descriptor are based on API entrypoints

Closes gravitee-io/issues#3277

* fix: Direct members permissions are not well merged with group permissions

Closes gravitee-io/issues#3315

* fix(): improve the rest-api swagger documentation

fix gravitee-io/issues#3230

* fix(users): display name show 'null' value if firstname or lastname is null

fixes gravitee-io/issues#3313

* fix(api): export API metadata

fixes gravitee-io/issues#3314

* fix(doc): remove List example in the rest-api swagger definition

* chore: Resolve swagger model type

* chore: Remove swagger2markup as it is covered with Redoc

* release(1.25.23)

* chore(): Prepare next version

* fix(api): Quality score is set to 0 if no custom rules has been validated

Closes gravitee-io/issues#3325

* fix(application): Set the client_id when updating a DCR application

Closes gravitee-io/issues#3180

* feat(dictionary): Provide support HTTP headers

Closes gravitee-io/issues#3296

* fix: When updating the view name, the label is not correct on the API's cards

fix gravitee-io/issues#3279

* feat(policy): Policies can be extracted from Swagger

Closes gravitee-io/issues#3298

* feat(alert): Add alert history

Closes gravitee-io/issues#3185

* fix(pages): do not override fetcher configuration while fetching pages

fixes gravitee-io/issues#3342

* feat(alert): Upgrade node dependencies to add support for alert on node healthcheck metrics

Closes gravitee-io/issues#3118

* fix(api): Add default context-path to API entity

Closes gravitee-io/issues#3356

* fix(analytics): add order metadata to group_by response to be able to sort data on the UI side

fixes gravitee-io/issues#3350

* feat(page): Add an option to render swagger server according to the entrypoint path

Closes gravitee-io/issues#3359

* fix(logs): Manage unknown API

Closes gravitee-io/issues#3349

* fix: missing license header

* fix(subscription): Api-key without expiration date are well managed

Closes gravitee-io/issues#3362

* release(1.30.6)

* chore(): Prepare next version

* release(1.30.7)

* chore(): Prepare next version

* fix: Support email message is displaying html elements

Closes gravitee-io/issues#3398

* fix(logging): Plug Java Util Logging (JUL) to SLF4J

Closes gravitee-io/issues#3360

* release(1.25.24)

* fix: Metadata are not well imported while creating or updating an API

Closes gravitee-io/issues#3409

* fix: Entrypoints are incorrect in case of virtual hosting configuration

Closes gravitee-io/issues#3404

* fix: Error on top path column name

fix gravitee-io/issues#3411

* release(1.30.8)

* chore(): Prepare next version

* fix(apikey): save paused subscriptions

fix gravitee-io/issues#3520

* fix(swagger): keep the swagger config on api update from swagger

fix gravitee-io/issues#3518

* fix(user): do not fail if default app is enabled but simple App with DCR is disabled

fix gravitee-io/issues#3523

* fix(subscriptions): search subscriptions by api-key with many applications

fixes gravitee-io/issues#3346

* fix(oidc-idp): map emailRequired property from gravitee.yml file

fixes gravitee-io/issues#3597

* fix: Allows to override virtual host with entrypoints

fix gravitee-io/issues#3626

* feat(memberhsip): Manage automatic membership mappings for identity providers

Closes gravitee-io/issues#1698

* fix(view): Default ALL view must have a key

Closes gravitee-io/issues#3636

* fix(UT): SubscriptionService + ApiService_ExportAsJsonTest

* chore(): upgrade parent to fix gpg error

* release(1.30.9)

* chore(): Prepare next version

* feat(messages): allow to optionally define whitelist url for post message

Closes gravitee-io/issues#3638

* fix: Add upport for CSRF / upgrade nimbus + upgrade java-jwt

Closes gravitee-io/issues#3634

* fix(image): Image format and content are validated against XSS attacks

Closes gravitee-io/issues#3648

* fix(api): improve filtering of api data

Closes gravitee-io/issues#3644

* fix(user): Check the email and password during registration

Closes gravitee-io/issues#3656

* chore(dependencies): upgrade dependencies

spring 5.1.3 -> 5.2.5
spring-security 5.1.5 -> 5.2.5
jersey 2.29 -> 2.30.1
jetty 9.4.20 -> 9.4.28
freemarker 2.3.28 -> 2.3.30
guava 20.0 -> 29.0-jre
json-path 2.3.0 -> 2.4.0
snakeyaml 1.18 -> 1.26
jackson 2.9.8 -> 2.10.3
json-schema-validator 2.2.8 -> 2.2.13
swagger-jersey-jaxrs 1.5.23 -> 1.6.1
jersey-spring4 -> jersey-spring5
java-jwt 2.2.1 -> 3.10.2

Closes gravitee-io/issues#3652

* feat(page): allow to optionally sanitize page content

Closes gravitee-io/issues#3637

* feat(import): add ability to whitelist urls or disable import from private host

Closes gravitee-io/issues#3657

* feat(csrf): allow to optionally enable csrf protection

Closes gravitee-io/issues#3663

* feat(captcha): add captcha protection if feature is enabled

Closes gravitee-io/issues#3655

* fix(user): Do not search on email domain

Closes gravitee-io/issues#3665

* feat(csrf): handle csrf cross-domain

Closes gravitee-io/issues#3662

* fix(csrf): handle csrf cross-domain

Closes gravitee-io/issues#3662

* feat(captcha): add captcha on login

Closes gravitee-io/issues#3655

* fix(import): security value for plan data can be filled in lowercase

Closes gravitee-io/issues#3402

* refactor: export api with enum vales in lowercase

Closes gravitee-io/issues#3406

* X-Forwarded headers fix for ports
 Closes: gravitee-io/issues#3641

* fix(csrf): set http-only on csrf cookie

Closes gravitee-io/issues#3673

* chore: Upgrade netty dependency

Closes gravitee-io/issues#3679

* feat(captcha): allow cors 'X-Recaptcha-Token' header by default

Closes gravitee-io/issues#3676

* chore: Upgrade gravitee-node dependency

Closes gravitee-io/issues#3419

* fix(command): do not fetch indexable source if the action is a delete one

fixes gravitee-io/issues#3574

* fix: Fail to save a Client registration config

fix gravitee-io/issues#3617

* release(1.30.10)

Co-authored-by: Gravitee.io Bot <contact@gravitee.io>
Co-authored-by: Nicolas Géraud <nicolas.geraud@gmail.com>
Co-authored-by: Azize Elamrani <azize.elamrani@gmail.com>
Co-authored-by: David BRASSELY <brasseld@gmail.com>
Co-authored-by: Titouan COMPIEGNE <titouan.compiegne@gmail.com>
Co-authored-by: Guillaume Gillon <guillaume.gillon@gmail.com>
Co-authored-by: Florent CHAMFROY <florent.chamfroy@graviteesource.com>
Co-authored-by: RomsDev <tabaryr@gmail.com>
Co-authored-by: Guillaume Cusnieux <guillaume.cusnieux@graviteesource.com>
Co-authored-by: Zdenek Obst <zdenek.obst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants