Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] [override theme] CRUD implementation at domain level #8121

Closed
2 tasks done
tcompiegne opened this issue Jul 15, 2022 · 1 comment
Closed
2 tasks done

Comments

@tcompiegne
Copy link
Member

tcompiegne commented Jul 15, 2022

🌈 Feature

Following #8120 :

As a 'security domain owner'

I want to 'to create / update / delete my theme'

So that 'I can match the branding needs of my company'

🌄 Additional information

  • We only manage the REST-API and not the UI since the the screen is pretty complex, will be split in other issue
  • CRUD operations from the UI to the data storage layer
  • Managing themes will require the DOMAIN_THEME permission at API level

🔗 Dependencies

#8120

📷 Mockups

📚 Documentation required

Provide link to the issue for documentation update

🦸 Acceptance criteria

  • Test the CRUD operations with Jest
  • Jest test for acceptance criteria

⚠️ Potential impacts

As we accept urls for favicon & logos, we should pay attention to Server-Side Request Forgery (SSRF).

What are the impacted versions?

🚀

@tcompiegne tcompiegne added this to the AM - 3.19.0 milestone Jul 15, 2022
@tcompiegne tcompiegne changed the title [management] [override theme] CRUD implementation [management] [override theme] CRUD implementation at domain level Jul 15, 2022
@omatthewsgravitee
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants