Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NET-1207): show network info on RAC #2949

Merged
merged 1 commit into from
Jun 3, 2024
Merged

feat(NET-1207): show network info on RAC #2949

merged 1 commit into from
Jun 3, 2024

Conversation

Aceix
Copy link
Contributor

@Aceix Aceix commented May 23, 2024

Describe your changes

this PR enables showing network info on RAC

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@abhishek9686 abhishek9686 merged commit d9237da into develop Jun 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishek9686 abhishek9686 abhishek9686 approved these changes

@theguy951357 theguy951357 Awaiting requested review from theguy951357

@yabinma yabinma Awaiting requested review from yabinma

@pwilson77 pwilson77 Awaiting requested review from pwilson77

@NEETweeb NEETweeb Awaiting requested review from NEETweeb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aceix @abhishek9686